Skip to content

fix: hide console window for stdio extensions on Windows #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 2 commits into from
Aug 14, 2025
Merged

fix: hide console window for stdio extensions on Windows #4085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28ec4d
fix: hide console window for stdio extensions on windows
jamadeo Aug 14, 2025
2fb1b0a
Name it
jamadeo Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/goose/src/agents/extension_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ impl ResourceItem {
}
}

#[cfg(windows)]
const CREATE_NO_WINDOW_FLAG: u32 = 0x08000000;

/// Sanitizes a string by replacing invalid characters with underscores.
/// Valid characters match [a-zA-Z0-9_-]
fn normalize(input: String) -> String {
Expand Down Expand Up @@ -111,6 +114,8 @@ async fn child_process_client(
) -> ExtensionResult<McpClient> {
#[cfg(unix)]
command.process_group(0);
#[cfg(windows)]
command.creation_flags(CREATE_NO_WINDOW_FLAG);
let (transport, mut stderr) = TokioChildProcess::builder(command)
.stderr(Stdio::piped())
.spawn()?;
Expand Down
Loading