Skip to content

Conversation

@lily-de
Copy link
Contributor

@lily-de lily-de commented Aug 4, 2025

example fix for what is missing currently

  1. Detects 401 errors and OAuth-requiring endpoints (like mcp.notion.com)
  2. Automatically triggers OAuth flow when connection fails
  3. Retries with Bearer token after successful authentication

@lily-de lily-de marked this pull request as draft August 4, 2025 18:33
@michaelneale
Copy link
Collaborator

oh very cool - this seems much needed

}
let client = reqwest::Client::builder()
.default_headers(default_headers)
.default_headers(default_headers.clone())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not always send the bearer token if can acquire one along here? if we can acquire it, we need it anyway

@jamadeo
Copy link
Collaborator

jamadeo commented Aug 6, 2025

Thank you @lily-de for jumping on this! I think we want to take this opportunity to use rmcp's oauth and drop our own implementation (#3845)

@DOsinga
Copy link
Collaborator

DOsinga commented Aug 13, 2025

closing - feel free to reopen when needed

@DOsinga DOsinga closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants