Skip to content

Conversation

@Developerayo
Copy link
Contributor

Fixes: #3777

  • Add support for configuring OpenAI/Anthropic compatible APIs (local or cloud)
  • Fix delete confirmation for custom & known providers
image image

@DOsinga DOsinga self-assigned this Aug 4, 2025
@DOsinga
Copy link
Collaborator

DOsinga commented Aug 4, 2025

this is awesome, thanks so much for doing this work!

I had been dabbling myself in this and took a slightly different approach. I hope we can combine the two efforts

here's my very much WIP:
#3825

it rejigs the whole factory stuff and then adds custom providers that can be read from json. they have an engine, i.e. which provider executes it. that's kinda nice because then we don't have to have actually extra providers in there. I went with Ollama and OpenAI because I saw people ask for that, but we can easily add Anthropic of course

@DOsinga DOsinga self-requested a review August 4, 2025 13:46
@Developerayo
Copy link
Contributor Author

this is awesome, thanks so much for doing this work!

I had been dabbling myself in this and took a slightly different approach. I hope we can combine the two efforts

here's my very much WIP: #3825

it rejigs the whole factory stuff and then adds custom providers that can be read from json. they have an engine, i.e. which provider executes it. that's kinda nice because then we don't have to have actually extra providers in there. I went with Ollama and OpenAI because I saw people ask for that, but we can easily add Anthropic of course

Ahh!! This is an excellent idea!
Could update this PR and inculcate your approach

@DOsinga
Copy link
Collaborator

DOsinga commented Aug 7, 2025

if you want to merge my PR into this and then make it all work, go for it! happy to close mine after that

@DOsinga DOsinga changed the base branch from main to custom-providers-infra August 8, 2025 10:07
@DOsinga
Copy link
Collaborator

DOsinga commented Aug 8, 2025

Ok, I'm going to give this a go to see if I can merge the two approaches. hold on!

@DOsinga
Copy link
Collaborator

DOsinga commented Aug 8, 2025

never mind, looks like you already did. checked out your branch and took it for a spin, this works pretty well! the only feedback I have here is that we could add a boolean to allow/disallow streaming (not all "compatible" backends support that) and we could consider moving some of the code that is being done in the config for the server (add custom provider) and the cli to the custom provider class so there's less repetition and we do less work in routes.

can you merge master in so we can get a clean diff? looking forward to getting this in the hands of people!

@DOsinga DOsinga changed the base branch from custom-providers-infra to main August 8, 2025 18:36
@DOsinga DOsinga mentioned this pull request Aug 8, 2025
@Developerayo
Copy link
Contributor Author

never mind, looks like you already did. checked out your branch and took it for a spin, this works pretty well! the only feedback I have here is that we could add a boolean to allow/disallow streaming (not all "compatible" backends support that) and we could consider moving some of the code that is being done in the config for the server (add custom provider) and the cli to the custom provider class so there's less repetition and we do less work in routes.

can you merge master in so we can get a clean diff? looking forward to getting this in the hands of people!

All resolved 🫡

Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work:

  • somehow the package-lock.json I think changed somehow
  • have a look at my suggestion to do more work in the custom_provider.rs
  • another thing to think about is that when you hit edit of a custom provider you get the default edit thing, instead of the configure custom provider

we can leave the last two for a follow up if you want though. would love to get this in for 1.3 which we should get ready for the coming week

@Developerayo Developerayo requested a review from DOsinga August 10, 2025 19:55
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the build things?

@Developerayo
Copy link
Contributor Author

can you fix the build things?

oops, resolved, should be all good now...

@DOsinga
Copy link
Collaborator

DOsinga commented Aug 13, 2025

can you have another look, they all seem to have failed. partially I think because there's changes to the package lock, but not to the actually installed packages. I still would love to get this in! also the commits are missing DCO which we sadly now require

@jamadeo jamadeo mentioned this pull request Aug 14, 2025
@DOsinga
Copy link
Collaborator

DOsinga commented Aug 14, 2025

I'll make sure this gets merged. thanks

@Developerayo Developerayo requested a review from DOsinga August 15, 2025 11:26
@DOsinga
Copy link
Collaborator

DOsinga commented Aug 19, 2025

thanks for doing this. I just merged this by cloning this and changing things, so I am going to close this, but hurray!

@DOsinga DOsinga closed this Aug 19, 2025
@Developerayo
Copy link
Contributor Author

Developerayo commented Aug 20, 2025

thanks for doing this. I just merged this by cloning this and changing things, so I am going to close this, but hurray!

🫡

...#4099

@DOsinga
Copy link
Collaborator

DOsinga commented Aug 25, 2025

let me know if you have any other good ideas you want to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add "OpenAI Compatible" and "Anthropic Compatible" provider configuration

2 participants