Skip to content

Remove unused Memory Mode / Computer-Controller Mode code #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanesq merged 1 commit into from
Jul 30, 2025
Merged

Remove unused Memory Mode / Computer-Controller Mode code #3743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions ui/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import log from './utils/logger';
import { ensureWinShims } from './utils/winShims';
import { addRecentDir, loadRecentDirs } from './utils/recentDirs';
import {
createEnvironmentMenu,
EnvToggles,
loadSettings,
saveSettings,
Expand Down Expand Up @@ -1824,25 +1823,6 @@ app.whenReady().then(async () => {
);
}

// Add Environment menu items to View menu
const viewMenu = menu?.items.find((item) => item.label === 'View');
if (viewMenu?.submenu) {
viewMenu.submenu.append(new MenuItem({ type: 'separator' }));
viewMenu.submenu.append(
new MenuItem({
label: 'Environment',
submenu: Menu.buildFromTemplate(
createEnvironmentMenu(envToggles, (newToggles) => {
envToggles = newToggles;
const currentSettings = loadSettings();
saveSettings({ ...currentSettings, envToggles: newToggles });
updateEnvironmentVariables(newToggles);
})
),
})
);
}

const fileMenu = menu?.items.find((item) => item.label === 'File');

if (fileMenu?.submenu) {
Expand Down
35 changes: 1 addition & 34 deletions ui/desktop/src/utils/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { app, MenuItem } from 'electron';
import { app } from 'electron';
import fs from 'fs';
import path from 'path';

Expand Down Expand Up @@ -78,36 +78,3 @@ export function updateSchedulingEngineEnvironment(schedulingEngine: SchedulingEn
process.env.GOOSE_SCHEDULER_TYPE = 'legacy';
}
}

// Menu management
export function createEnvironmentMenu(
envToggles: EnvToggles,
onToggle: (newToggles: EnvToggles) => void
) {
return [
{
label: 'Enable Memory Mode',
type: 'checkbox' as const,
checked: envToggles.GOOSE_SERVER__MEMORY,
click: (menuItem: MenuItem) => {
const newToggles = {
...envToggles,
GOOSE_SERVER__MEMORY: menuItem.checked,
};
onToggle(newToggles);
},
},
{
label: 'Enable Computer Controller Mode',
type: 'checkbox' as const,
checked: envToggles.GOOSE_SERVER__COMPUTER_CONTROLLER,
click: (menuItem: MenuItem) => {
const newToggles = {
...envToggles,
GOOSE_SERVER__COMPUTER_CONTROLLER: menuItem.checked,
};
onToggle(newToggles);
},
},
];
}
Loading