Skip to content

Conversation

@glenn-sq
Copy link
Contributor

This pull request updates the CI workflow configuration to optimize when the workflow is triggered. The most important change is the addition of paths-ignore rules to exclude documentation-only changes from triggering the CI workflow.

Workflow optimization:

  • .github/workflows/ci.yml: Added paths-ignore rules under both pull_request and merge_group triggers to prevent the CI workflow from running for changes made exclusively in the documentation/** directory.

@glenn-sq glenn-sq marked this pull request as ready for review July 29, 2025 12:47
Copy link
Collaborator

@angiejones angiejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont want to skip ALL tests as the documentation directory is what powers our website, recipe library, prompt library etc. so we need some checks. Just not the ones that are testing the actual goose app/CLI.

@glenn-sq glenn-sq requested a review from angiejones July 29, 2025 18:23
@angiejones angiejones self-assigned this Jul 30, 2025
Instead of skipping the entire CI workflow for documentation-only changes,
this makes the optimization more granular by:

- Adding a 'changes' job to detect which files have changed
- Only skipping expensive jobs (rust-format, rust-build-and-test, desktop-lint, bundle-desktop-unsigned) for docs-only PRs
- Keeping the workflow running so other important checks (DCO, security scans, etc.) continue to work
- Using dorny/paths-filter for reliable file change detection

This approach saves significant CI resources for documentation PRs while
maintaining all necessary checks for code changes.
Clean up the workflow by removing the explanatory comments
for the conditional job logic.
Pin dorny/paths-filter@v3 to commit SHA de90cc6fb38fc0963ad72b210f1f284cd68cea36
to address the security alert about third-party actions not being pinned.
@angiejones angiejones merged commit 45adf4e into block:main Jul 30, 2025
8 checks passed
michaelneale added a commit that referenced this pull request Jul 30, 2025
* main:
  skip app-related CI jobs for doc/blog PRs (#3704)
  Blog:How OpenRouter Unlocked Our Workshop Strategy (#3726)
lifeizhou-ap added a commit that referenced this pull request Jul 30, 2025
* main:
  Ok, well, that got out of hand (#3718)
  feat: openrouter out of the box experience for goose installations (#3507)
  Iand/make goosehints blog post visible (#3729)
  skip app-related CI jobs for doc/blog PRs (#3704)
  Blog:How OpenRouter Unlocked Our Workshop Strategy (#3726)
@glenn-sq glenn-sq deleted the skip_ci_for_docs branch July 30, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants