Skip to content

Conversation

@michaelneale
Copy link
Collaborator

@michaelneale michaelneale commented Jul 23, 2025

testing this out locally - but this ads autosummarize/compact to the clients calling agent

this is to augment the https://github.com/block/goose/tree/dkatz/goose-compact2 PR

@katzdave
Copy link
Collaborator

Cool, taking this for a spin

katzdave added 2 commits July 23, 2025 15:37
…enhance

* 'main' of github.com:block/goose:
  docs: use installer component for tutorial, add updating extensions section (#3608)
  fix: show token alert popover during agent responses and agent failure cases (#3536)
  reuse the cancellation token in the agent level (#3599)
  Docs: Move MongoDB tutorial to MCP section (#3602)
  docs: desktop recipe format (#3594)
  Fix model display name not being updated immediately after leaving settings (#3587)
  Added option to summarize the chat when an error is triggered (#3598)
@katzdave
Copy link
Collaborator

katzdave commented Jul 23, 2025

Ok this is pretty cool! I don't find it super disruptive seeing the summary take over, and then run the prompt. Would be great if we added more clarity that's happening before that but overall a pretty nice experience.

I'm game to merge into my branch.

So here's what I pieced together is I think a lot of the anomalies come from this inherited behavior where we rip out the last tool call response and then insert it back in. Especially when you're dealing with the jsonl files, those can be huge, so leads to situations where you summarize and then end up back with an 80k context (because it's basically just the orignal jsonl from the last tool call coming back.

I think doesn't explain the session dying randomly, but I pushed a version with that tool call response filter ripped out. Now the summaries are actually super tiny, not sure if this will degrade performance. Tested a little bit and seems to generally be fine; especially since we don't summarize until the session cedes control back to the user, so I don't see why the recent tool call would be that important; goose can make it again if necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-07-24 17:02 UTC

@michaelneale
Copy link
Collaborator Author

agree - I think we are over indexing on tool call results, absorbing them all vs sipping on them, so agree with that change - is that on your other branch?

@katzdave katzdave merged commit 970b197 into dkatz/goose-compact2 Jul 24, 2025
4 checks passed
@katzdave katzdave deleted the micn/auto-compact-enhance branch July 24, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants