Lifei/sub recipe desktop temp #3576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (28 commits) fix: multi-tool calls in streamed openai-compatible responses (#3609) feat: subagent turn count, simple agent loop (#3597) feat: subagent independent extension manager (#3596) Improve session history loading resiliency (#3588) Added logging and changed default route case to not redirect to home when there is an invalid route (#3610) fix: chat sidebar layout overlapping content occasionally (#3590) fix: loading shared sessions (#3607) docs: use installer component for tutorial, add updating extensions section (#3608) fix: show token alert popover during agent responses and agent failure cases (#3536) reuse the cancellation token in the agent level (#3599) Docs: Move MongoDB tutorial to MCP section (#3602) docs: desktop recipe format (#3594) Fix model display name not being updated immediately after leaving settings (#3587) Added option to summarize the chat when an error is triggered (#3598) Remove mcp_macros and unused types (#3581) fix: add fallback id to messages if none provided (#3584) feat: migrate ErrorData from internal mcp crates to rmcp version (#3586) fix: adjust subrecipe description to allow running tests (#3585) Scenario tests (#3430) feat: migrate JsonRpcMessage/Request/Response/Error/Notification from internal mcp crates to rmcp versions (#3564) ...
…unning subrecipe cli
DOsinga
approved these changes
Jul 24, 2025
| truncate_with_ellipsis(&clean_output, OUTPUT_PREVIEW_LENGTH) | ||
| } | ||
|
|
||
| fn truncate_with_ellipsis(text: &str, max_len: usize) -> String { |
Collaborator
There was a problem hiding this comment.
this is wrong by the way, we should use use goose::utils::safe_truncate;
| } | ||
| } | ||
|
|
||
| fn strip_ansi_codes(text: &str) -> String { |
Collaborator
There was a problem hiding this comment.
maybe move this to utils?
| import { SubRecipe } from '../api'; | ||
| import { getApiUrl, getSecretKey } from '../config'; | ||
|
|
||
| export async function addSubRecipes(subRecipes: SubRecipe[]) { |
Collaborator
There was a problem hiding this comment.
eh, shouldn't this be generated code through our openapi thing?
| if (subRecipes && subRecipes?.length > 0) { | ||
| for (const subRecipe of subRecipes) { | ||
| if (subRecipe.values) { | ||
| // Iterate over each key in subRecipe.values and substitute parameters |
katzdave
added a commit
that referenced
this pull request
Jul 24, 2025
* 'main' of github.com:block/goose: Adds the `WaitingForUserInput` state (#3620) docs: update extensions library (#3612) Fixing grants path (#3632) docs: June 2024 Community All-Stars Spotlight (#3631) grant program (#3630) Lifei/sub recipe desktop temp (#3576) docs: local LLMs context size tip (#3454) fix: Handle non-default base path for OpenAI compatible model fetching (#3566) Goose security updates (#3579) fix: multi-tool calls in streamed openai-compatible responses (#3609) feat: subagent turn count, simple agent loop (#3597) feat: subagent independent extension manager (#3596) Improve session history loading resiliency (#3588) Added logging and changed default route case to not redirect to home when there is an invalid route (#3610) fix: chat sidebar layout overlapping content occasionally (#3590) fix: loading shared sessions (#3607)
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 25, 2025
* main: docs: Quick spotlight fix (#3633) alexhancock/rmcp-tools-annotations (#3617) fix: clean up subagent (#3565) Adds the `WaitingForUserInput` state (#3620) docs: update extensions library (#3612) Fixing grants path (#3632) docs: June 2024 Community All-Stars Spotlight (#3631) grant program (#3630) Lifei/sub recipe desktop temp (#3576)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is a temporary implementation to get sub recipe working in Desktop as some of our users would like to use it in the Desktop
What
/agent/add_sub_recipesto add subrecipe tools to agent/agent/add_sub_recipesstrip_ansi_codestoagentpackage instead ofgoose-cliso that thesub_agent_execution_tooltool result does not contain the ansi_codes from thegoose run --recipe subrecipecli outputLimitation
goose clito run the sub recipeWhat needs to do properly