fix: Fixes structured output after streaming change to agent #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een stream chunks
jsibbison-square
changed the title
DOsinga
reviewed
Jul 16, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_when_final_output_not_called_in_reply() -> Result<()> { |
jamadeo
approved these changes
Jul 16, 2025
Collaborator
jamadeo
left a comment
jamadeo
left a comment
There was a problem hiding this comment.
Nice test thanks @jsibbison-square
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 16, 2025
* main: fix: Fixes structured output after streaming change to agent (#3448)
jamadeo
pushed a commit
that referenced
this pull request
Jul 16, 2025
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
) Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
) Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
) Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When streaming was introduced #2677 a bug was introduced around structured output. Every text streaming chunk has no tool calls and so the inner loop would check if final output had been recorded yet and send a warning directive to the agent rather than waiting till the end of the llm's response.
Added a test that would have caught this (tested against main).