-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore: implement streaming for anthropic.rs firstparty provider #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice thanks @michaelneale ! when I run it the streaming looks good but my token count stays at 0 -- maybe not pulling the usage out correctly? |
|
Turns out I had a similar issue with OpenAI: #3441 Is there a similar flag for Anthropic? |
|
oh interesting, yes will take a look |
|
adding in some logging... trying to see where the token counts are coming in: according to docs: https://docs.anthropic.com/en/docs/build-with-claude/streaming but am not seeing it - hrm... will have to put this on the back burner for a bit as not clear for a while. need to read some more. if anyone knows and picks this up - go for it but will revisit it. |
|
ok that took more time than I had hoped - it seems you have to accumulate/calculate as you go. |
jamadeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this worked for me.
* main: feat(gcpvertexai): do HTTP 429 like retries for Anthropic API HTTP 529 overloaded status code (#3026) Fix a few ui edge cases - refresh occasionally crashing, chat loader over text and chat input height returning to auto (#3469) Don't default to main for build-cli (#3467) docs: add MongoDB MCP server tutorial (#2660) feat: run sub recipe multiple times in parallel (Experimental feature) (#3274) chore(release): release version 1.1.0 (#3465) chore: implement streaming for anthropic.rs firstparty provider (#3419) Fix regression: add back detail to tool-call banners (#3231) Document release process and update some just recipes (#3460) feat: add download_cli.ps1 file for windows (#3354) fix: session_file is optional (#3462) Bump more space for goose is working on it so it doesnt overlap incoming agent chat messages (#3453) Align chat input action buttons to bottom when large amount of text (#3455) docs: add Cloudflare MCP Server tutorial (#3278) feat(cli): Clear persisted session file with /clear command (#3145)
…k#3419) Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
…k#3419) Signed-off-by: Kyle Santiago <kyle@privkey.io>
…k#3419) Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
Similar to openai: #3413
this adds in streaming for anthropic provider