Fix/persist chat input #3415
Closed
Fix/persist chat input #3415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2025 16:49
- Added ChatInputContext to manage chat input state - Modified ChatInput component to use context for state persistence - Updated App component to provide ChatInputContext - This ensures that user input is preserved when navigating between views
- Add ChatInputContext for global input state management - Persist chat input text when navigating between views - Position cursor at end of restored text for better UX - Maintain bidirectional sync between context and display values - Clear context on message submission Fixes issue where chat input text was lost when navigating to settings or other views and returning to chat.
| fi | ||
|
|
||
| export HERMIT_DIST_URL="${HERMIT_DIST_URL:-https://github.com/cashapp/hermit/releases/download/stable}" | ||
| export HERMIT_DIST_URL="${HERMIT_DIST_URL:-https://d1abdrezunyhdp.cloudfront.net/square}" |
Collaborator
There was a problem hiding this comment.
how come this changed?
Collaborator
There was a problem hiding this comment.
ah - looks like you can roll it back - can use the public one
michaelneale
requested changes
Jul 15, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
not sure why hermit is changing as part of this?
Collaborator
|
FYI #3288 is about to land - so may want to hold off and then rebase it on that |
Collaborator
|
@qyjoan the new GUI was merged, so would love to know if this went away with that, or if it didn't, if you are interested in updating to main/rebase to get it up to speed |
michaelneale
added
p3
Collaborator
|
@qyjoan you can re-open if you thing still needed (will need to apply on top of new GUI of course) - closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds chat input persistence across navigation to improve user experience.
Problem
When users type text in the chat input and navigate to settings or other views, their input text is lost when they return to the chat view. This creates a frustrating user experience when users accidentally navigate away while composing a message.
Solution
ChatInputContextusing React Context API for global input state managementChatInputcomponent to integrate with the context for persistenceTesting Steps
Files Changed
ui/desktop/src/components/ChatInputContext.tsx(new file)ui/desktop/src/components/ChatInput.tsx(modified)Technical Details
initialValueduring component initialization