Skip to content

Fix name of GPT-4.1 System Prompt (#3348) #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yingjiehe-xyz merged 2 commits into from
Jul 10, 2025
Merged

Fix name of GPT-4.1 System Prompt (#3348) #3351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae19755
Fix name of GPT-4.1 System Prompt (#3348)
simonsickle Jul 10, 2025
6b451a3
Fix tests for GPT 4.1 system prompt
simonsickle Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/goose/src/agents/prompt_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl PromptManager {
/// Map model (normalized) to prompt filenames; returns filename if a key is contained in the normalized model
fn model_prompt_map(model: &str) -> &'static str {
let mut map = HashMap::new();
map.insert("gpt_4_1", "system_gpt_4_1.md");
map.insert("gpt_4_1", "system_gpt_4.1.md");
// Add more mappings as needed
let norm_model = Self::normalize_model_name(model);
for (key, val) in &map {
Expand Down Expand Up @@ -185,25 +185,25 @@ mod tests {
// should match prompts based on contained normalized keys
assert_eq!(
PromptManager::model_prompt_map("gpt-4.1"),
"system_gpt_4_1.md"
"system_gpt_4.1.md"
);

assert_eq!(
PromptManager::model_prompt_map("gpt-4.1-2025-04-14"),
"system_gpt_4_1.md"
"system_gpt_4.1.md"
);

assert_eq!(
PromptManager::model_prompt_map("openai/gpt-4.1"),
"system_gpt_4_1.md"
"system_gpt_4.1.md"
);
assert_eq!(
PromptManager::model_prompt_map("goose-gpt-4-1"),
"system_gpt_4_1.md"
"system_gpt_4.1.md"
);
assert_eq!(
PromptManager::model_prompt_map("gpt-4-1-huge"),
"system_gpt_4_1.md"
"system_gpt_4.1.md"
);
}

Expand Down
Loading