Skip to content

Enabling npx command to install on Windows Desktop #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackgirlbytes merged 1 commit into from
Jul 7, 2025
Merged

Enabling npx command to install on Windows Desktop #3283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/desktop/src/components/settings/extensions/deeplink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function getStdioConfig(
timeout: number
) {
// Validate that the command is one of the allowed commands
const allowedCommands = ['cu', 'docker', 'jbang', 'npx', 'uvx', 'goosed'];
const allowedCommands = ['cu', 'docker', 'jbang', 'npx', 'uvx', 'goosed', 'npx.cmd'];
if (!allowedCommands.includes(cmd)) {
toastService.handleError(
'Invalid Command',
Expand Down
2 changes: 1 addition & 1 deletion ui/desktop/src/components/settings/extensions/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export async function replaceWithShims(cmd: string) {

export function removeShims(cmd: string) {
// Only remove shims if the path matches our known shim patterns
const shimPatterns = [/cu$/, /goosed$/, /docker$/, /jbang$/, /npx$/, /uvx$/];
const shimPatterns = [/cu$/, /goosed$/, /docker$/, /jbang$/, /npx$/, /uvx$/, /npx.cmd$/];

// Check if the command matches any shim pattern
const isShim = shimPatterns.some((pattern) => pattern.test(cmd));
Expand Down
1 change: 1 addition & 0 deletions ui/desktop/src/extensions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ export async function replaceWithShims(cmd: string) {
jbang: await window.electron.getBinaryPath('jbang'),
npx: await window.electron.getBinaryPath('npx'),
uvx: await window.electron.getBinaryPath('uvx'),
'npx.cmd': await window.electron.getBinaryPath('npx.cmd'),
};

if (binaryPathMap[cmd]) {
Expand Down
Loading