Skip to content

Fix regression: add back detail to tool-call banners #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katzdave merged 1 commit into from
Jul 16, 2025
Merged

Fix regression: add back detail to tool-call banners #3231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ui/desktop/src/components/ToolCallWithResponse.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ function ToolCallView({
if (args.window_title) {
return `capturing window "${truncate(getStringValue(args.window_title))}"`;
}
return 'capturing screen';
return `capturing screen`;

case 'automation_script':
if (args.language) {
Expand All @@ -289,23 +289,29 @@ function ToolCallView({
return 'final output';

case 'computer_control':
return 'poking around...';
return `poking around...`;

default: {
// Fallback to showing key parameters for unknown tools
// Generic fallback for unknown tools: ToolName + CompactArguments
// This ensures any MCP tool works without explicit handling
const toolDisplayName = snakeToTitleCase(toolName);
const entries = Object.entries(args);
if (entries.length === 0) return null;

if (entries.length === 0) {
return `${toolDisplayName}`;
}

// For a single parameter, show key and truncated value
if (entries.length === 1) {
const [key, value] = entries[0];
const stringValue = getStringValue(value);
const truncatedValue = truncate(stringValue, 30);
return `${key}: ${truncatedValue}`;
return `${toolDisplayName} ${key}: ${truncatedValue}`;
}

// For multiple parameters, just show the keys
return entries.map(([key]) => key).join(', ');
// For multiple parameters, show tool name and keys
const keys = entries.map(([key]) => key).join(', ');
return `${toolDisplayName} ${keys}`;
}
}

Expand All @@ -325,7 +331,7 @@ function ToolCallView({
if (description) {
return description;
}
// Fallback to the original tool name formatting
// Fallback tool name formatting
return snakeToTitleCase(toolCall.name.substring(toolCall.name.lastIndexOf('__') + 2));
})()}
</span>
Expand Down