Clean up session file optionality for --no-session #3230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
changed the title
jamadeo
commented
Jul 2, 2025
| }) | ||
| .await; | ||
| setup_logging( | ||
| session.session_file().file_stem().and_then(|s| s.to_str()), |
Collaborator
Author
There was a problem hiding this comment.
This is new behavior -- setup_logging takes an Option<&str>, but here we'd pass it /dev/null which becomes a log file like 20250521_154141-null.log.
After this change, we'll pass None, which just becomes 20250521_154141.log
Kvadratni
approved these changes
Jul 2, 2025
wpfleger96
added a commit
to wpfleger96/goose
that referenced
this pull request
Jul 2, 2025
* main: Defend against invalid sessions (block#3229) Clean up session file optionality for --no-session (block#3230) Feat: Support Recipe Parameters in Goose desktop app (block#3155) docs: update recipe example (block#3222) Add native OAuth 2.0 authentication support to MCP client (block#3213) build: Check in Cargo.lock changes (block#3220) fix: fix desktop recipe url generation (block#3209) feat: improve UX for saving recipes (block#3214)
baxen
added a commit
to Developerayo/goose
that referenced
this pull request
Jul 2, 2025
* main: (150 commits) Defend against invalid sessions (block#3229) Clean up session file optionality for --no-session (block#3230) Feat: Support Recipe Parameters in Goose desktop app (block#3155) docs: update recipe example (block#3222) Add native OAuth 2.0 authentication support to MCP client (block#3213) build: Check in Cargo.lock changes (block#3220) fix: fix desktop recipe url generation (block#3209) feat: improve UX for saving recipes (block#3214) fix: Pass Google AI API key in HTTP header, not query param (block#3192) docs: add linter to CONTRIBUTING.md (block#3168) feat: Structured output for recipes (block#3188) Fix cost tracking accuracy and OpenRouter model pricing (block#3189) docs: update cli install instructions for windows (block#3205) Docs: Cost tracking on the desktop app (block#3204) feat: Adding streamable-http transport support for backend, desktop and cli (block#2942) fix: use the correct `contains` syntax on create-recipe-pr.yml (block#3193) Temporarily Remove GH Copilot Provider (block#3199) docs: fix tab navigation (block#3201) feat: use tiktoken-rs instead of tokenizers, single global tokenizer (block#3115) add playwright-mcp server to extensions list (block#3010) ...
jsibbison-square
added a commit
that referenced
this pull request
Jul 2, 2025
…x-turns * origin/main: Defend against invalid sessions (#3229) Clean up session file optionality for --no-session (#3230) Feat: Support Recipe Parameters in Goose desktop app (#3155) docs: update recipe example (#3222) Add native OAuth 2.0 authentication support to MCP client (#3213) build: Check in Cargo.lock changes (#3220) fix: fix desktop recipe url generation (#3209) feat: improve UX for saving recipes (#3214) fix: Pass Google AI API key in HTTP header, not query param (#3192) docs: add linter to CONTRIBUTING.md (#3168)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Jul 14, 2025
Signed-off-by: Adam Tarantino <[email protected]>
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using /dev/null or flags, make the session file optional on the agent and only try to save when we have one.
Closes #3228