feat: GUI can use structured output present in recipes #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeizhou-ap
reviewed
Jul 3, 2025
| // Get recipeConfig directly here | ||
| const recipeConfig = window.appConfig?.get?.('recipeConfig'); | ||
| const botPrompt = (recipeConfig as { instructions?: string })?.instructions; | ||
| const responseConfig = (recipeConfig as { response?: { json_schema?: unknown } })?.response; |
Collaborator
There was a problem hiding this comment.
I guess you have to add response attribute on the RecipeConfig interface on the client side, and populate to the object when parsing the deeplink.
If you have tested this and it is works, that means my statement above is wrong :)
Contributor
Author
There was a problem hiding this comment.
Yeah it works, recipeConfig gets populated early in the process, its pretty cryptic.
lifeizhou-ap
reviewed
Jul 3, 2025
|
|
||
| // Configure session with response config if present | ||
| if (responseConfig?.json_schema) { | ||
| const sessionConfigResponse = await fetch(getApiUrl('/agent/session_config'), { |
Collaborator
There was a problem hiding this comment.
Shall we move this api call to another module? the function is getting longer :)
Collaborator
|
just curious about this feature. It is good to see the output, but from user's prospective, what kind of use case/experience that they want the output? |
lifeizhou-ap
approved these changes
Jul 3, 2025
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Jul 14, 2025
Signed-off-by: Adam Tarantino <[email protected]>
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
Signed-off-by: Kyle Santiago <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't give the gui the ability to view or edit structured output but if structured output is part of the recipe it will now be used. Support in CLI was added in #3188