Fix clippy + test errors

[zanesq]

Fixes

error: useless conversion to the same type: types::core::ToolCall
--> crates/goose-llm/src/message/mod.rs:154:20
|
154 |                 Ok(ToolCall::new("test_tool", json!({"param": "value"})).into()),
|                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing .into(): ToolCall::new("test_tool", json!({"param": "value"}))
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: -D clippy::useless-conversion implied by -D warnings
= help: to override -D warnings add #[allow(clippy::useless_conversion)]


error: assert!(false, ..) should probably be replaced
--> crates/mcp-client/examples/integration_test.rs:27:18
|
27 |         Ok(_) => assert!(false, "Expected an error but got success"),
|                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: use panic!(..) or unreachable!(..)
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
= note: -D clippy::assertions-on-constants implied by -D warnings
= help: to override -D warnings add #[allow(clippy::assertions_on_constants)]


error: useless conversion to the same type: types::core::ToolCall
--> crates/goose-llm/src/providers/formats/databricks.rs:684:20
|
684 |                 Ok(ToolCall::new("example", json!({"param1": "value1"})).into()),
|                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing .into(): ToolCall::new("example", json!({"param1": "value1"}))
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion


error: the borrowed expression implements the required traits
--> crates/goose-llm/src/providers/formats/databricks.rs:804:35
|
804 |         std::fs::write(&png_path, &png_data)?;
|                                   ^^^^^^^^^ help: change this to: png_data
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: -D clippy::needless-borrows-for-generic-args implied by -D warnings
= help: to override -D warnings add #[allow(clippy::needless_borrows_for_generic_args)]


error: could not compile mcp-client (example "integration_test") due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: the borrowed expression implements the required traits
--> crates/goose-llm/src/providers/formats/openai.rs:677:35
|
677 |         std::fs::write(&png_path, &png_data)?;
|                                   ^^^^^^^^^ help: change this to: png_data
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args


error: the borrowed expression implements the required traits
--> crates/goose-llm/src/providers/utils.rs:280:35
|
280 |         std::fs::write(&png_path, &png_data).unwrap();
|                                   ^^^^^^^^^ help: change this to: png_data
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args


error: the borrowed expression implements the required traits
--> crates/goose-llm/src/providers/utils.rs:318:35
|
318 |         std::fs::write(&png_path, &png_data).unwrap();
|                                   ^^^^^^^^^ help: change this to: png_data
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args


error: could not compile goose-llm (lib test) due to 6 previous errors
error: unnecessary use of to_path_buf
--> crates/goose-mcp/src/developer/mod.rs:1698:49
|
1698 |         let mut builder = GitignoreBuilder::new(temp_dir.path().to_path_buf());
|                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: temp_dir.path()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
= note: -D clippy::unnecessary-to-owned implied by -D warnings
= help: to override -D warnings add #[allow(clippy::unnecessary_to_owned)]


error: unnecessary use of to_path_buf
--> crates/goose-mcp/src/developer/mod.rs:1750:49
|
1750 |         let mut builder = GitignoreBuilder::new(temp_dir.path().to_path_buf());
|                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: temp_dir.path()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned


error: unnecessary use of to_path_buf
--> crates/goose-mcp/src/developer/mod.rs:1810:49
|
1810 |         let mut builder = GitignoreBuilder::new(temp_dir.path().to_path_buf());
|                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: temp_dir.path()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned


error: could not compile goose-mcp (lib test) due to 3 previous errors

and

failures:

---- routes::audio::tests::test_transcribe_endpoint_handles_invalid_base64 stdout ----

thread 'routes::audio::tests::test_transcribe_endpoint_handles_invalid_base64' panicked at crates/goose-server/src/routes/audio.rs:472:9:
assertion `left == right` failed
  left: 412
 right: 400
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- routes::audio::tests::test_transcribe_endpoint_validates_mime_type stdout ----

thread 'routes::audio::tests::test_transcribe_endpoint_validates_mime_type' panicked at crates/goose-server/src/routes/audio.rs:445:9:
assertion `left == right` failed
  left: 412
 right: 415


failures:
    routes::audio::tests::test_transcribe_endpoint_handles_invalid_base64
    routes::audio::tests::test_transcribe_endpoint_validates_mime_type

test result: FAILED. 16 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.65s

error: test failed, to rerun pass `-p goose-server --lib`