feat: created sub recipe tools #2982

lifeizhou-ap · 2025-06-18T11:15:05Z

What

Added tools for sub recipes
Fixed the recipe validation and rendering. Template handling are as below:
- when running recipe goose run --recipe...
  1. parse the recipe content with the inheritance, and extract recipe parameters and template variables.
  2. validate the params
  3. render the recipe (final recipe) with params and inheritance if any parameters are not provided, it will fail
- when explaining recipe goose run --recipe ... --explain
  1 parse the recipe content with the inheritance, and extract recipe parameters and template variables.
  2. validate the params
  3. render the recipe with params and inheritance (if not all params are provided, it won't fail)
- when validating or creating deep link for recipe goose recipe deeplink ..., goose receipe validate ...
  1 . parse the recipe content with the inheritance, and extract recipe parameters and template variables.
  2. validate the params
  3. ender the recipe with inheritance but without any params

lifeizhou-ap · 2025-06-18T11:16:10Z

crates/goose-cli/src/recipes/recipe.rs

    }
 }

-fn parse_recipe_content(content: &str) -> Result<Recipe> {


moved to goose package to be reusable

lifeizhou-ap · 2025-06-18T11:19:18Z

crates/goose/src/agents/agent.rs

 pub struct Agent {
    pub(super) provider: Mutex<Option<Arc<dyn Provider>>>,
    pub(super) extension_manager: Mutex<ExtensionManager>,
+    pub(super) sub_recipe_manager: Mutex<SubRecipeManager>,


I created a sub_recipe_manager to manage sub recipe tools and trigger the sub recipe tool call.

I could also use the extension manager to add these tool, but the extension manager is mainly for MCP. So I create a sub_recipe_manager, maybe later it could evolve to sub_agent_manager

This seems great. They are distinct from extensions so I think that makes sense. It also leaves the door open to agents treating sub-recipes differently: instead of shelling out to a new goose, a future version may use the same agent or a new in-process instance

…ram is defined in the main recipe

jamadeo

Very nice! I'll test this out and report back with any findings

jamadeo · 2025-06-18T13:44:30Z

crates/goose/src/agents/recipe_tools/sub_recipe_tools.rs

+            read_only_hint: true,
+            destructive_hint: false,
+            idempotent_hint: false,
+            open_world_hint: false,


do we know that open_world is false? should we just leave it out?

good catch! I just used the default, will modify that

jamadeo · 2025-06-18T14:33:45Z

crates/goose/src/agents/agent.rs

 pub struct Agent {
    pub(super) provider: Mutex<Option<Arc<dyn Provider>>>,
    pub(super) extension_manager: Mutex<ExtensionManager>,
+    pub(super) sub_recipe_manager: Mutex<SubRecipeManager>,


This seems great. They are distinct from extensions so I think that makes sense. It also leaves the door open to agents treating sub-recipes differently: instead of shelling out to a new goose, a future version may use the same agent or a new in-process instance

jamadeo · 2025-06-18T15:03:58Z

crates/goose/src/agents/recipe_tools/sub_recipe_tools.rs

+
+use crate::recipe::{Recipe, RecipeParameter, RecipeParameterRequirement, SubRecipe};
+
+pub const SUB_RECIPE_TOOL_NAME_PREFIX: &str = "subrecipe__run_sub_recipe";


I'm not sure how much it matters, but since the models themselves don't really know what a recipe is, you could probably just use run__{recipe name} or something like that to name the tools

jamadeo · 2025-06-18T15:04:25Z

crates/goose/src/agents/recipe_tools/sub_recipe_tools.rs

+    let stderr_output = stderr_task.await.unwrap();
+
+    if status.success() {
+        Ok(stdout_output)


we should probably also return stderr to the model, right?

jamadeo · 2025-06-18T15:05:13Z

crates/goose/src/agents/sub_recipe_manager.rs

+    }
+
+    pub fn is_sub_recipe_tool(&self, tool_name: &str) -> bool {
+        tool_name.starts_with(SUB_RECIPE_TOOL_NAME_PREFIX)


here you might as well just test for membership in the map, rather than the prefix

jamadeo · 2025-06-18T15:06:42Z

crates/goose/src/agents/sub_recipe_manager.rs

+        for sub_recipe in sub_recipes_to_add {
+            let sub_recipe_name = sub_recipe.name.clone();
+            let tool = create_sub_recipe_tool(&sub_recipe);
+            self.sub_recipe_tools.insert(sub_recipe_name.clone(), tool);


if you instead store them in the map using their prefixed names, it will make them easier to look up in call_sub_recipe_tool() and is_sup_recipe_tool()

* main: Blog: Add video to container use blog (#3008) Use official logo in Goose web (#3012) fix shims for extensions on windows (#3009) fix powershell executions (#3006) Docs linux desktop (#3007) Platform Tool for Scheduler: Allow Goose to Manage Its Own Schedule (#2944) docs: container use blog and guide (#2962) Fix: Workflow syntax (#3002) Added just lint-ui for linting front end code (#2997) fix typo in secret name (#2994) feat(ui): add chain-of-thought panel above assistant messages (#2899) feat(cli): Add `--quiet /-q` flag to goose run (#2939) Feat: Recipe Library (#2946) Docs: Goose on Windows Installation (#2990) Fixes : Workflow error on issue comment (#2958) Add a setting for the quit confirmation dialog (#2901) Update bundle-desktop-windows.yml (#2988) feat: optional fast edit models (#2580) feat: Add lead-worker model selection and real-time model display in GUI (#2964)

* main: fix: Improves reliability of flaky log tests (#3029) Add xAI Test Coverage (#3020) Reorganizing tutorials (#3028) feat(providers): update Google Gemini models to latest available models (#2989) fix(docker): install protoc to fix lance-encoding build (#2995) fix: updated openrouter known models (#3021) Mnovich/temporal foreground tasks (#2895) add 'install in goose' asset (#3016) Added useDarkMode hook for detecting dark mode setting dynamically (#3019) docs: add sagemaker provider (#2980) Docs: Add Goose Recipes Cookbook Page (#2998) feat (cli): add an alias --id for --name param for goose session --resume command (#3018) fix: disable extension (#3000) Add xAI Provider Support for Grok Models (#2976) removing dlls from core bin (#3014) docs: Update Leaderboard in New Community Landing Page (#2954) Douwe/fix include for recipes (#2914)

lifeizhou-ap · 2025-06-24T05:51:29Z

crates/goose-cli/src/recipes/recipe.rs

-}
-
 #[cfg(test)]
-mod tests {


tests are moved to a separate files

* origin/main: Session file security updates (#3071) feat(ui): Add drag and drop support for opening sessions from finder. (#3070) Mnovich/fix cli permisisons (#3074) copy permission fix for cli (#3073) Update download_cli.sh to support arbitrary Goose versions (#3060) fix(temporal-service): makes the search for possible temporal paths parallel. (#3062) added MCPs menu item (#3066) fix missing dependencies for cli (#3065) feat: created sub recipe tools (#2982) attempt to build CLI native for Windows (#3058) docs: typo - wrong extension id (#3063) fix(docs): teach Goose how to spell “autonomous” 🪿📚 (#3061) feat (cli): list Groq-supported models (#3048) Fix session corruption issues (#3052) feat: update to get vector db path from env var for vector tool strategy (#3042) Fix Linux desktop download links to point to actual desktop versions (#3051) fix temporal build for windows (#3045) fix cron parsing for windows (#3044)

Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>

lifeizhou-ap added 5 commits June 18, 2025 15:00

add sub recipe tools

cc207bb

added sub recipe manager in agent

cc870fb

added the parameter management

ad67286

print out the command output

285149a

refactoring and cleanup

1a32ff7

lifeizhou-ap commented Jun 18, 2025

View reviewed changes

lifeizhou-ap added 6 commits June 18, 2025 21:30

rename functions

f610962

fixed the type of the param value

1db66e8

changed the sub recipe attribute name

65923b3

cleanup

77ab90c

added test cases

8d5d4dd

removed test recipes

94308e0

lifeizhou-ap changed the title ~~Lifei/sub recipe tool~~ feat: created sub recipe tools Jun 18, 2025

lifeizhou-ap marked this pull request as ready for review June 18, 2025 13:32

not providing tool params for sub recipe tools if the value of the pa…

8592fb0

…ram is defined in the main recipe

jamadeo approved these changes Jun 18, 2025

View reviewed changes

jamadeo mentioned this pull request Jun 18, 2025

(experiment) sub-recipes prototype #2862

Closed

lifeizhou-ap added 7 commits June 20, 2025 14:40

address pr comments

6c26884

fixed the format

559217f

fixed merge conflicts

69db1a3

fixed the recipe validation and rendering

7e39000

add tests

6042707

lifeizhou-ap commented Jun 24, 2025

View reviewed changes

crates/goose-cli/src/recipes/recipe.rs

}

#[cfg(test)]

mod tests {

Copy link

Collaborator Author

lifeizhou-ap Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are moved to a separate files

fixed tests

9822f66

lifeizhou-ap merged commit 9e6247d into main Jun 24, 2025
7 checks passed

lifeizhou-ap deleted the lifei/sub-recipe-tool branch June 24, 2025 23:29

chaitanyarahalkar mentioned this pull request Jun 25, 2025

feat: add side panel UX with search capabilities chaitanyarahalkar/goose#7

Open

s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025

feat: created sub recipe tools (block#2982)

7d8ce1a

Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025

feat: created sub recipe tools (block#2982)

39c9909


		use crate::recipe::{Recipe, RecipeParameter, RecipeParameterRequirement, SubRecipe};

		pub const SUB_RECIPE_TOOL_NAME_PREFIX: &str = "subrecipe__run_sub_recipe";

feat: created sub recipe tools #2982

feat: created sub recipe tools #2982

Uh oh!

Conversation

lifeizhou-ap commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jamadeo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lifeizhou-ap commented Jun 18, 2025 •

edited

Loading

lifeizhou-ap Jun 18, 2025 •

edited

Loading