Skip to content

Conversation

@salman1993
Copy link
Contributor

@salman1993 salman1993 commented Jun 10, 2025

Changes:

  • update example to add toolResult status error
  • fix bug to lower/lift Tool Result. "status" field not showing for tool calls. instead rust Result object's "Ok" field was showing.

@salman1993 salman1993 requested a review from zhong-sq June 10, 2025 22:40
Copy link

@zhong-sq zhong-sq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@salman1993 salman1993 merged commit 2bdfe5b into main Jun 11, 2025
7 checks passed
@salman1993 salman1993 deleted the sm/fix-serde-deserialize branch June 11, 2025 23:24
opdich added a commit to opdich/goose that referenced this pull request Jun 12, 2025
* upstream/main:
  Docs: Fix readme (block#2880)
  fix: CPU hogging GUI (block#2877)
  feat/fix: don't stop cli starting if MCPs don't load (block#2860)
  fix invalid context length for claude models (block#2872)
  dynamic port selection for temporal (block#2865)
  Docs: Session Export via CLI (block#2867)
  Docs: Adding Snowflake as a Provider (block#2868)
  [goose-llm] update example to add toolResult status error (block#2854)
  fix: cap the repeat time when display usage (block#2864)
lifeizhou-ap added a commit that referenced this pull request Jun 13, 2025
* main: (26 commits)
  docs: update Snowflake link and description verbiage (#2882)
  Fixed typos and wording for endpoint info for ollama (#2861)
  Docs: Unlist blog post called What's in my goosehints file (#2891)
  Docs: Fix Nav Bar and wrong command in docs (#2889)
  fix the claude model name (#2890)
  disable temporal by default (#2886)
  feat(desktop): Add auto-update functionality to Goose desktop app (#2852)
  docs: add goose web command (#2856)
  Docs: Schedule recipes with the CLI (#2881)
  Docs: Fix readme (#2880)
  fix: CPU hogging GUI (#2877)
  feat/fix: don't stop cli starting if MCPs don't load (#2860)
  fix invalid context length for claude models (#2872)
  dynamic port selection for temporal (#2865)
  Docs: Session Export via CLI (#2867)
  Docs: Adding Snowflake as a Provider (#2868)
  [goose-llm] update example to add toolResult status error (#2854)
  fix: cap the repeat time when display usage (#2864)
  Docs: Goose now respects gitignore files (#2858)
  docs: add CLI token usage (#2857)
  ...
laanak08 added a commit that referenced this pull request Jun 16, 2025
…ch-datasets

# By Wendy Tang (7) and others
# Via GitHub (1) and Wendy Tang (1)
* wtang/generalize_vector_search:
  add llm strategy
  redundant disk cleanup
  clean up more disk space
  docs: add goose web command (#2856)
  Docs: Schedule recipes with the CLI (#2881)
  Docs: Fix readme (#2880)
  fix: CPU hogging GUI (#2877)
  feat/fix: don't stop cli starting if MCPs don't load (#2860)
  fix invalid context length for claude models (#2872)
  dynamic port selection for temporal (#2865)
  Docs: Session Export via CLI (#2867)
  Docs: Adding Snowflake as a Provider (#2868)
  Llm
  fmt
  [goose-llm] update example to add toolResult status error (#2854)
  fmt
  llm tool selector
  fix: cap the repeat time when display usage (#2864)
  Docs: Goose now respects gitignore files (#2858)

# Conflicts:
#	crates/goose-cli/src/commands/bench.rs
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants