Cleanup phase 4: Fix complex type issues and IPC handler compatibility #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix App.tsx complex type issues:
- Add safe type assertions for initializeSystem parameters (provider as string, model as string)
Already null-checked with if (provider && model) so assertions are safe
- Fix all Electron IPC event handlers with 'as any' casts for type compatibility
Electron's .on() expects (...args: unknown[]) but we provide typed handlers
- Fix View type casting for viewFromUrl parameter
- Fix implicit any parameter types:
- ChatView.tsx: Add explicit ChatType for prevChat parameter in setChat callback
- GoosehintsModal.tsx: Add comprehensive prop types for all components:
* Modal: children: React.ReactNode
* ModalError: error: any
* ModalFileInfo: filePath: string; found: boolean
* ModalButtons: onSubmit/onCancel function types
* getGoosehintsFile: filePath: string parameter
- Reduces TypeScript errors by 19 (from 350 to 331)
- Higher complexity fixes while maintaining runtime safety
- Eliminates implicit any types with proper type annotations
- Total progress: 69+ errors eliminated across all phases (400+ → 331)
zanesq
changed the title
alexhancock
approved these changes
May 29, 2025
zanesq
merged commit 35a07cd
into
fix/typescript-errors-phase3-null-checks
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix App.tsx complex type issues:
Fix implicit any parameter types:
Reduces TypeScript errors by 19 (from 350 to 331)
Higher complexity fixes while maintaining runtime safety
Eliminates implicit any types with proper type annotations
Total progress: 69+ errors eliminated across all phases (400+ → 331)