Cleanup: Fix/typescript errors phase2 unused variables #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix unused parameters by prefixing with underscore (TypeScript convention): - ProviderSetupModal.tsx: _model: _, _endpoint: __ - OllamaBattleGame.tsx: requiredKeys: _ (with comprehensive fixes) - AddModelModal.tsx: _isValid: _, _validationErrors: __ - main.ts: Multiple unused event parameters → _event, version → _version - Fix OllamaBattleGame.tsx completely: - Remove unused React import - Fix Audio type from custom to HTMLAudioElement - Fix computed property with null check for configKey - Fix function type casting for choices array/function - Add comprehensive asset type declarations (PNG, MP3, etc.) - Reduces TypeScript errors by ~20 (from 381 to 361) - All changes use TypeScript conventions for intentionally unused parameters - No functionality changes, purely cleanup and type safety improvements
alexhancock
approved these changes
May 29, 2025
zanesq
merged commit bfc11f0
into
fix/typescript-errors-phase1-unused-react-imports
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unused parameters by prefixing with underscore (TypeScript convention):
Fix OllamaBattleGame.tsx completely:
Reduces TypeScript errors by ~20 (from 381 to 361)
All changes use TypeScript conventions for intentionally unused parameters
No functionality changes, purely cleanup and type safety improvements