Skip to content

feat: extract StdioProcessError(msg) to try to display #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalvinnchau merged 3 commits into from
Mar 25, 2025
Merged

feat: extract StdioProcessError(msg) to try to display #1855

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af85be3
feat: attempt to capture StdioProcessError(msg) msg to display if < 1…
kalvinnchau Mar 25, 2025
873c09c
fix: ToastError changed to using traceback instead of errorMessage
kalvinnchau Mar 25, 2025
d5c7db5
docs: add comment on error message extraction
kalvinnchau Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions ui/desktop/src/extensions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,23 @@ export async function addExtension(
return response;
}

const errorMessage = `Error adding extension`;
console.error(errorMessage);
var errorMessage = `Error adding extension`;
// Attempt to extract the message from inside StdioProcessError()
// NOTE: this may change if the error response from /extensions/add changes
const regex = /StdioProcessError\("(.*?)"\)/;
const match = data.message.match(regex);

if (match) {
const extracted = match[1];
// only display the message if it is less than 100 chars
errorMessage = extracted.length > 100 ? errorMessage : extracted;
}

if (toastId) toast.dismiss(toastId);
ToastError({
title: extension.name,
msg: errorMessage,
errorMessage: data.message,
traceback: data.message,
toastOptions: { autoClose: false },
});

Expand All @@ -122,7 +132,7 @@ export async function addExtension(
ToastError({
title: extension.name,
msg: 'Failed to add extension',
errorMessage: error.message,
traceback: error.message,
toastOptions: { autoClose: false },
});
throw error;
Expand Down Expand Up @@ -154,7 +164,7 @@ export async function removeExtension(name: string, silent: boolean = false): Pr
ToastError({
title: name,
msg: 'Error removing extension',
errorMessage: data.message,
traceback: data.message,
toastOptions: { autoClose: false },
});
return response;
Expand All @@ -164,7 +174,7 @@ export async function removeExtension(name: string, silent: boolean = false): Pr
ToastError({
title: name,
msg: 'Error removing extension',
errorMessage: error.message,
traceback: error.message,
toastOptions: { autoClose: false },
});
throw error;
Expand Down
Loading