-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: extensions read config #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
210aa64
update config check to handle special cases
lily-de 764c87d
update configured providers after submitting
lily-de 28313e9
remove print statements
lily-de e60a227
remove comment
lily-de d89fac8
move to utils file
lily-de b134bcf
format
lily-de 238871a
read, write, toggle extensions
lily-de cb2abe8
use keys internally and names externally
lily-de 1042ac2
everything but cli toggling
lily-de 712a612
toggle works
lily-de 54a8d2b
remove commented out code
lily-de af4e1bb
revert
lily-de 3c6167f
revert to name
lily-de 4ffd1ae
format
lily-de debd8fe
lint
lily-de 694850b
remove file
lily-de dd72246
remove reference
lily-de 41f3779
lint
lily-de 1a68c92
get rid of unneeded stuff
lily-de b3c1dd5
update name to key
lily-de 1e589c4
lint
lily-de File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like we are applying a similar filter twice below, should the existing iter/filter/map be removed or consolidated ?