Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/goose-bench/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ serde = { version = "1.0", features = ["derive"] }
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["registry"] }
tokio = { version = "1.0", features = ["full"] }
include_dir = "0.7.4"

[target.'cfg(target_os = "windows")'.dependencies]
winapi = { version = "0.3", features = ["wincred"] }
18 changes: 15 additions & 3 deletions crates/goose-bench/src/bench_work_dir.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
use chrono::Local;
use include_dir::{include_dir, Dir};
use std::fs;
use std::io;
use std::io::ErrorKind;
use std::path::Path;
use std::path::PathBuf;
use std::process::Command;

pub static BUILTIN_EVAL_ASSETS: Dir = include_dir!("$CARGO_MANIFEST_DIR/src");

pub struct BenchmarkWorkDir {
pub base_path: PathBuf,
cwd: PathBuf,
Expand All @@ -16,7 +19,7 @@ pub struct BenchmarkWorkDir {

impl Default for BenchmarkWorkDir {
fn default() -> Self {
BenchmarkWorkDir::new("work_dir".to_string(), Vec::new())
Self::new("work_dir".to_string(), Vec::new())
}
}
impl BenchmarkWorkDir {
Expand All @@ -42,9 +45,11 @@ impl BenchmarkWorkDir {
// deep copy each dir
let _: Vec<_> = dirs
.iter()
.map(|d| BenchmarkWorkDir::deep_copy(d.as_path(), base_path.as_path(), true))
.map(|d| Self::deep_copy(d.as_path(), base_path.as_path(), true))
.collect();

Self::copy_auto_included_dirs(&base_path);

std::env::set_current_dir(&base_path).unwrap();

BenchmarkWorkDir {
Expand All @@ -55,6 +60,13 @@ impl BenchmarkWorkDir {
eval: None,
}
}
fn copy_auto_included_dirs(dest: &PathBuf) {
BUILTIN_EVAL_ASSETS
.get_dir("assets")
.unwrap()
.extract(dest)
.unwrap();
}
pub fn cd(&mut self, path: PathBuf) -> anyhow::Result<&mut Self> {
fs::create_dir_all(&path)?;
std::env::set_current_dir(&path)?;
Expand Down Expand Up @@ -132,7 +144,7 @@ impl BenchmarkWorkDir {
let here = PathBuf::from(".").canonicalize()?;
let artifact_at_root = self.base_path.clone().join(asset_rel_path);

BenchmarkWorkDir::deep_copy(artifact_at_root.as_path(), here.as_path(), true)?;
Self::deep_copy(artifact_at_root.as_path(), here.as_path(), true)?;
Ok(PathBuf::from(path))
}

Expand Down
4 changes: 2 additions & 2 deletions crates/goose-cli/src/commands/bench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ async fn run_eval(

async fn run_suite(suite: &str, work_dir: &mut BenchmarkWorkDir) -> anyhow::Result<SuiteResult> {
let mut suite_result = SuiteResult::new(suite.to_string());
let eval_lock = Mutex::new(0);
let eval_lock = Mutex::new(());

if let Some(evals) = EvaluationSuiteFactory::create(suite) {
for eval in evals {
Expand Down Expand Up @@ -152,7 +152,7 @@ pub async fn run_benchmark(
format!("{}-{}", provider_name, goose_model),
include_dirs.clone(),
);
let suite_lock = Mutex::new(0);
let suite_lock = Mutex::new(());
for suite in suites {
let _unused = suite_lock.lock().await;
work_dir.set_suite(suite);
Expand Down
Loading