feat: store working directory for sessions #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. **URL Parameter Approach**: - When resuming a session, we now pass the session ID as a URL parameter to the new window - This ensures the session ID is correctly passed between windows 2. **Main Process Changes**: - Updated the `createChat` function to accept a `resumeSessionId` parameter - Modified the URL loading code to include the resumeSessionId parameter - Updated the IPC handler to pass the resumeSessionId parameter 3. **Preload Script Changes**: - Updated the `createChatWindow` function to accept and pass the resumeSessionId parameter 4. **SessionsView Changes**: - Modified the `handleResumeSession` function to directly pass the session ID to the new window - Removed the localStorage approach which was causing issues 5. **App.tsx Changes**: - Added an effect to check for the resumeSessionId parameter in the URL - If found, it fetches the session details and switches to the chat view with the resumed session 6. **ChatView Cleanup**: - Simplified the ChatView component by removing the complex state management - Removed the code that was causing the infinite loop - Kept only the essential code for displaying resumed sessions This approach is much cleaner and more reliable because: 1. It uses the URL parameter system which is designed for passing data between windows 2. It avoids the localStorage approach which was causing issues 3. It directly fetches the session details in the new window 4. It eliminates the complex state management that was causing the infinite loop
nahiyankhan
approved these changes
Mar 6, 2025
kalvinnchau
reviewed
Mar 6, 2025
kalvinnchau
approved these changes
Mar 6, 2025
michaelneale
approved these changes
Mar 7, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
very cool! that looks like a heavy lift
lily-de
pushed a commit
that referenced
this pull request
Mar 7, 2025
ahau-square
pushed a commit
that referenced
this pull request
Mar 7, 2025
michaelneale
added a commit
that referenced
this pull request
Mar 9, 2025
* main: feat: parallel processing in approve mode (#1575) Feat: support auto-including dirs in binary/bench-work-dir (#1576) refactor models component (#1535) docs: Add running Goose in CI tutorial (#1426) chore: remove logging of oauth config, just log where we output (#1573) feat: implement a tool permission store (#1516) minor typo (#1569) fix: open new session in working dir when hotkey is pressed (#1570) feat: store working directory for sessions (#1559) docs: extension timeout (#1567) fix: update openrouter referer website to point to github page site (#1566) feat(cli): add --debug flag to goose session / run (#1564)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: