Skip to content

one pre-flight check to rule them all #5649

@codefromthecrypt

Description

@codefromthecrypt

Please explain the motivation behind the feature request.

I work in many different projects and sometimes I forget to run either of clippy or cargo fmt. Since running build checks require approval, this introduces quite a delay.

It is a let down when timezones are involved, when you finally get enough attention to click approve on the PR only for it to fail for some minor reason, then need to go back, invariably rebase and do any merge conflict and then try again.

Describe the solution you'd like

Several projects I work on have a make precommit or make check which let you run all the style things in one go.

Sometimes, that same thing does all the things CI would, though I understand we have maybe too many slow tests to want to make an "uber test"

I would like this in goose. a one-step way to do all the style related things.

Describe alternatives you've considered

Remember to re-read AGENTS.md, for the steps since they are there, also

cargo fmt
./scripts/clippy-lint.sh
cargo clippy --fix

Additional context

Bonus points for some way to run the same bot tests locally (copilot AI assistant is recently enabled), so that you don't get style passing but then the bot finds another style you need to hunt down.

  • I have verified this does not duplicate an existing feature request

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedGreat issue for non-Block contributors

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions