Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify code block display #4182

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

wesbillman
Copy link
Collaborator

  • Improve formatting to make things more consistent
  • Removes highlight.js and just reuses codemirror everywhere.
  • New component for showing code with a title
  • Better light mode handling
  • New maxHeight option

BEFORE:
Screenshot 2025-01-24 at 1 09 02 PM
Screenshot 2025-01-24 at 1 09 10 PM

AFTER:
Screenshot 2025-01-24 at 1 04 29 PM
Screenshot 2025-01-24 at 1 04 36 PM

@wesbillman wesbillman requested a review from a team as a code owner January 24, 2025 20:11
@alecthomas alecthomas mentioned this pull request Jan 24, 2025
@wesbillman wesbillman force-pushed the unify-code-component-in-console branch from 361656b to c908ee1 Compare January 24, 2025 20:12
@alecthomas alecthomas mentioned this pull request Jan 24, 2025
- improve formatting to make things more consistent
@wesbillman wesbillman force-pushed the unify-code-component-in-console branch from c908ee1 to 6131956 Compare January 24, 2025 20:15
@wesbillman wesbillman merged commit 57cf1b9 into main Jan 24, 2025
64 checks passed
@wesbillman wesbillman deleted the unify-code-component-in-console branch January 24, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant