fix(mobile): preserve exact mention recipients in saved drafts - #7387
Draft
loganj wants to merge 2 commits into
Draft
fix(mobile): preserve exact mention recipients in saved drafts#7387loganj wants to merge 2 commits into
loganj wants to merge 2 commits into
Conversation
loganj
force-pushed
the
fix/mobile-durable-mentions-20260905
branch
2 times, most recently
from
September 7, 2026 15:07
6fd3b66 to
5696495
Compare
Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
force-pushed
the
fix/mobile-durable-mentions-20260905
branch
from
September 7, 2026 15:11
5696495 to
8a78110
Compare
Collaborator
Author
Independent durable-mention readiness evidence — 2026-09-07Verified current stacked range:
2026-09-07 update: the stale composed reference described above has been retired — the |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Saved drafts remembered their text but not exactly who each mention referred to: reopening a draft (or restarting the app) could re-bind a mention to the wrong same-name teammate, and a draft restored in one thread could capture text arriving for another. This PR saves the exact selected identities alongside the draft text and restores them together, so a reopened draft names the same recipients — with their agent markings — that you picked, including after a failed send.
Related issue
Testing
just mobile-check, the full mobile test suite, and full localjust ciall pass — receipts in the exact-head evidence comment.To see it: mention an agent or a namesake, leave the channel, restart the app, and return — the draft still names the exact recipients you picked.
Screenshots
Flutter production-widget test renders — not native-device screenshots or acceptance captures.
Capture provenance
Rendered by the Flutter widget engine in a
flutter testrun (production widgets, production theme; no device or simulator). Before: this PR's declared base39afd73b0adfde14164f4b10dbd089cb498312b6. After: its head8a781108507dc4501192b0101185decc1ed6f118.