docs(nip-fi): document Git smart-HTTP credential exemption - #7268
Merged
Conversation
Document why standard Git smart HTTP cannot bind NIP-98 to each method, endpoint, or body. Keep per-request NIP-FI identity verification and Git-specific compensating controls normative. Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
🔐 Codex Security Review
Review SummaryOverall Risk: HIGH
Findings[HIGH]
|
wpfleger96
added a commit
that referenced
this pull request
Sep 3, 2026
Rebase onto c328202 (git smart-HTTP exemption amendment merged as #7268). Update NIP-FI.md line references throughout nip_fi_http.rs, bridge.rs, and workflows.rs to match the amended spec's new line numbers: - NIP-FI.md:547-567 / :547-578 -> :594-607 (carrier spec / no-fallback clause) - NIP-FI.md:579-597 -> :619-637 (payload-binding clause) - NIP-FI.md:584-587 -> :624-627 (deny-set check) Update route inventory comment to cite the merged git exemption with PR and commit references (#7268 / c328202, NIP-FI.md:545-583). Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
pushed a commit
that referenced
this pull request
Sep 3, 2026
…-enforcement * origin/main: docs(nip-fi): document Git smart-HTTP credential exemption (#7268) feat(cli): add buzz gifs command group and NIP-30 emoji tags on messages (#7259) feat(desktop): add persistent Bestie experience (#7223) fix(desktop): harden profile batch and thread-reply fetches against relay slowness (#7188) Signed-off-by: Hayt <9e1c23a3fd83f61da34420e4e88ff1b16e45cafcc0cd9019eb07d4ecfa8ca9b0@buzz.block.builderlab.xyz>
brow
added a commit
that referenced
this pull request
Sep 3, 2026
…eway-origin * origin/main: fix(desktop): derive agent availability from relay presence (#7127) fix(desktop): preserve spacing after multi-word mentions (#7128) docs(nip-fi): document Git smart-HTTP credential exemption (#7268) feat(cli): add buzz gifs command group and NIP-30 emoji tags on messages (#7259) feat(desktop): add persistent Bestie experience (#7223) fix(desktop): harden profile batch and thread-reply fetches against relay slowness (#7188) docs(nip-fi): adopt deny-until-TTL and extend enforcement to HTTP ingress (#7254) fix(composer): align wrapped inline chip fragments (#7242) Add operation-aware database pool acquisition metrics (#7195) Signed-off-by: Tom Brow <tomb@block.xyz>
wpfleger96
pushed a commit
that referenced
this pull request
Sep 3, 2026
* origin/main: 🤖 fix(desktop): harden smoke E2E tests against Bestie overlay and toast timing (#7270) Show status and huddle indicators beside names (#7112) Add mobile voice notes (#7121) perf(desktop): publish mention sends before waking agents (#7154) fix(desktop): unify owned-agent cloud provenance markers (#7129) fix(desktop): derive agent availability from relay presence (#7127) fix(desktop): preserve spacing after multi-word mentions (#7128) docs(nip-fi): document Git smart-HTTP credential exemption (#7268) feat(cli): add buzz gifs command group and NIP-30 emoji tags on messages (#7259) Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amend NIP-FI HTTP ingress with an explicit Git smart-HTTP credential-helper exemption. The exception covers method binding, endpoint-URL binding, and the
payloadtag requirement forinfo/refs,git-upload-pack, andgit-receive-pack, while preserving per-request NIP-FI assertion, key pairing, and deny-map enforcement.The spec records Git's credential-protocol limitation, the required compensating controls, and the rule that this exception is limited to these endpoints and is superseded by per-request signing.
Related: PR #7264