Skip to content

feat: add databricks fable 5.1 model capabilities - #7213

Merged
kalvinnchau merged 1 commit into
mainfrom
am/goose-claude-fable-5-1
Sep 1, 2026
Merged

feat: add databricks fable 5.1 model capabilities#7213
kalvinnchau merged 1 commit into
mainfrom
am/goose-claude-fable-5-1

Conversation

@kalvinnchau

@kalvinnchau kalvinnchau commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add the canonical public Databricks Claude Fable 5.1 model record
  • match the existing Fable family contract: adaptive thinking, low|medium|high|xhigh|max, default high, Anthropic Messages, and no normalization
  • add generated Rust/TypeScript corpus coverage and canonical Global Defaults label/persistence coverage
  • remove deployment-specific catalog references from the repository

Scope

This is metadata and regression coverage only. It does not change model-capability resolution or production frontend logic.

Validation

  • cargo fmt --check
  • node --test desktop/src/features/agents/ui/modelCapabilitiesCorpus.test.mjs
  • cargo test -p buzz-agent
  • pnpm build:e2e
  • pnpm exec playwright test --project=smoke --grep 'defaults render the Fable 5.1 label without changing the persisted id' — 1 passed
  • repository search for the removed catalog prefix — no matches

@kalvinnchau
kalvinnchau requested a review from a team as a code owner September 1, 2026 21:58
@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 42aeb1571cc1f1ed4d73f05b420474be970021ab...7e2492e5d5a47c2c5275970c8717fdebd6de1792.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 7e2492e5d5a47c2c5275970c8717fdebd6de1792 to authorize a new review.
Any previous review applies only to its recorded range.

@kalvinnchau
kalvinnchau force-pushed the am/goose-claude-fable-5-1 branch from 1052a95 to 8e2bf76 Compare September 1, 2026 22:14
am @kalvinnchau
feat: add databricks fable 5.1 model metadata
7e2492e 
Co-authored-by: Kalvin Chau <kalvin@block.xyz>
Signed-off-by: Kalvin Chau <kalvin@block.xyz>
@kalvinnchau
kalvinnchau force-pushed the am/goose-claude-fable-5-1 branch from 8e2bf76 to 7e2492e Compare September 1, 2026 22:24
wpfleger96
wpfleger96 approved these changes Sep 1, 2026
View reviewed changes

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source review is clean at exact head 7e2492e5d5a47c2c5275970c8717fdebd6de1792.

I traced the new manifest record through Rust routing/body construction and the TypeScript label path. The live Databricks contract also holds: the production serving endpoint reports Claude Fable 5.1, and direct requests to /ai-gateway/anthropic/v1/messages with adaptive thinking succeeded at both high and max effort while preserving the configured endpoint ID. The generated 140-vector Rust/TypeScript corpus and Global Defaults regression bind the relevant production seams.

Non-blocking observation: a dedicated goose-claude-fable-5-1 alias vector would improve parity with the existing Fable 5 coverage, but the shared alias path is already covered and the exact production endpoint added here is directly tested.

wpfleger96
wpfleger96 requested changes Sep 1, 2026
View reviewed changes

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required Global Defaults display behavior fails at exact head 7e2492e5d5a47c2c5275970c8717fdebd6de1792.

Independent live verification ran the added focused Playwright test and observed global-agent-model render the raw value databricks-claude-fable-5-1 rather than Claude Fable 5.1; data-value correctly remained the raw ID. The Databricks execution route itself passed.

Please wire Global Defaults to the label resolver so this endpoint renders Claude Fable 5.1 without mutating the persisted ID, then rerun the focused E2E. I am superseding my earlier approval based on this runtime evidence.

wpfleger96
wpfleger96 approved these changes Sep 1, 2026
View reviewed changes

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseding my changes-requested review at exact head 7e2492e5d5a47c2c5275970c8717fdebd6de1792. The reported label failure was invalid: direct playwright test reused a stale desktop/dist, while the repository E2E entry point runs pnpm build:e2e first.

A clean rebuild followed by the same focused test passes, rendering Claude Fable 5.1 while preserving data-value="databricks-claude-fable-5-1" and the persisted raw ID. I also verified PR #7135’s merge commit is an ancestor of this exact head and the current source routes the field through resolveModelLabel. No source change is required.

Source review, clean-build UI evidence, live Databricks execution, and completed applicable CI lanes are clean. The PR is approved.

@kalvinnchau
kalvinnchau merged commit 560fea7 into main Sep 1, 2026
44 checks passed
@kalvinnchau
kalvinnchau deleted the am/goose-claude-fable-5-1 branch September 1, 2026 23:06
johnmatthewtennant added a commit that referenced this pull request Sep 2, 2026
@johnmatthewtennant
Merge remote-tracking branch 'origin/main' into jtennant/project-stat…
055493f 
…e-read-model

* origin/main:
  fix(desktop): retain automatic mentions only in threads (#7144)
  feat: add databricks fable 5.1 model capabilities (#7213)
  docs(nip-fi): rewrite NIP-FI as stateless OSS Buzz spec v2 (#7214)
  feat(relay): add detailed readiness metrics (#7149)
  feat(desktop): add Pi agent preset (#7208)

Signed-off-by: John Tennant <jtennant@squareup.com>
johnmatthewtennant added a commit that referenced this pull request Sep 2, 2026
@johnmatthewtennant
Merge remote-tracking branch 'origin/jtennant/project-state-read-mode…
f8f54e5 
…l' into jtennant/project-state-mutations

* origin/jtennant/project-state-read-model:
  Fix historical migration catalog tests
  fix(desktop): retain automatic mentions only in threads (#7144)
  feat: add databricks fable 5.1 model capabilities (#7213)
  docs(nip-fi): rewrite NIP-FI as stateless OSS Buzz spec v2 (#7214)
  feat(relay): add detailed readiness metrics (#7149)
  feat(desktop): add Pi agent preset (#7208)

Signed-off-by: John Tennant <jtennant@squareup.com>
johnmatthewtennant added a commit that referenced this pull request Sep 2, 2026
@johnmatthewtennant
Merge remote-tracking branch 'origin/jtennant/project-state-mutations…
7d409e8 
…' into jtennant/project-related-channels-desktop

* origin/jtennant/project-state-mutations:
  Fix Project channel preservation test
  Fix historical migration catalog tests
  fix(desktop): retain automatic mentions only in threads (#7144)
  feat: add databricks fable 5.1 model capabilities (#7213)
  docs(nip-fi): rewrite NIP-FI as stateless OSS Buzz spec v2 (#7214)
  feat(relay): add detailed readiness metrics (#7149)
  feat(desktop): add Pi agent preset (#7208)

Signed-off-by: John Tennant <jtennant@squareup.com>
wpfleger96 pushed a commit that referenced this pull request Sep 2, 2026
Duncan
Merge remote-tracking branch 'origin/main' into duncan/canvas-version…
c4b1eb7 
…-history

* origin/main:
  fix(acp): replace real user name in base prompt mention example (#7250)
  ci: split CI into reusable workflows (#7168)
  fix(desktop): retain automatic mentions only in threads (#7144)
  feat: add databricks fable 5.1 model capabilities (#7213)
  docs(nip-fi): rewrite NIP-FI as stateless OSS Buzz spec v2 (#7214)
  feat(relay): add detailed readiness metrics (#7149)
  feat(desktop): add Pi agent preset (#7208)
  feat(buzz-agent): add DatabricksAuthCoordinator single-flight OAuth (#5545)
  fix(desktop): preserve keyring identity during recovery (#7203)
  feat(mobile): prepare `buzz-push-gateway` for deployment (#7158)
  ci: relax file-size ceilings by surface (#6485)
  fix(mobile): isolate extension linker flags; complete iOS build in CI (#7187)
  chore(ci): lower Codex security review effort (#7179)
  fix(dev-mcp): extend shell timeout cap to 20 minutes and align outer budgets (#7185)
  fix(dev): keep the canonical profile when launching from desktop/ (#7143)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
wpfleger96 pushed a commit that referenced this pull request Sep 2, 2026
Duncan
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
51486b2 
* origin/main:
  feat(agents): harness-agnostic effort write path and spawn bridge (#4625)
  chore(db): drop Phase-A NIP-FI relay-side authority ledger (#7221)
  fix(acp): replace real user name in base prompt mention example (#7250)
  ci: split CI into reusable workflows (#7168)
  fix(desktop): retain automatic mentions only in threads (#7144)
  feat: add databricks fable 5.1 model capabilities (#7213)
  docs(nip-fi): rewrite NIP-FI as stateless OSS Buzz spec v2 (#7214)
  feat(relay): add detailed readiness metrics (#7149)
  feat(desktop): add Pi agent preset (#7208)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

# Conflicts:
#	desktop/src-tauri/src/commands/agent_models_update.rs
#	desktop/src-tauri/src/commands/agents_deploy.rs
#	desktop/src-tauri/src/managed_agents/types/requests.rs
#	desktop/src/features/agents/ui/AgentInstanceEditDialog.tsx
#	desktop/src/shared/api/types.ts
wpfleger96 pushed a commit that referenced this pull request Sep 2, 2026
Duncan
Merge remote-tracking branch 'origin/main' into duncan/phase1-merged-…
08d1193 
…agent-edit

* origin/main:
  feat(desktop): add persistent Bestie experience (#7223)
  fix(desktop): harden profile batch and thread-reply fetches against relay slowness (#7188)
  docs(nip-fi): adopt deny-until-TTL and extend enforcement to HTTP ingress (#7254)
  fix(composer): align wrapped inline chip fragments (#7242)
  Add operation-aware database pool acquisition metrics (#7195)
  fix(desktop): keep explicit agent profiles bound to their exact key (#7131)
  fix(desktop): discover authenticated owned relay agents (#7122)
  feat(agents): harness-agnostic effort write path and spawn bridge (#4625)
  chore(db): drop Phase-A NIP-FI relay-side authority ledger (#7221)
  fix(acp): replace real user name in base prompt mention example (#7250)
  ci: split CI into reusable workflows (#7168)
  fix(desktop): retain automatic mentions only in threads (#7144)
  feat: add databricks fable 5.1 model capabilities (#7213)
  docs(nip-fi): rewrite NIP-FI as stateless OSS Buzz spec v2 (#7214)
  feat(relay): add detailed readiness metrics (#7149)
  feat(desktop): add Pi agent preset (#7208)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

# Conflicts:
#	desktop/src/features/agents/ui/AgentInstanceEditDialog.tsx
#	desktop/src/features/agents/ui/agentInstanceEditPinning.test.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpfleger96 wpfleger96 wpfleger96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalvinnchau @wpfleger96