fix(desktop): show an agent in @ search after you add it to a channel

desktop/playwright.config.ts

@@ -78,6 +78,7 @@ export default defineConfig({
         "**/mention-spacing.spec.ts",
         "**/mention-recipients.spec.ts",
         "**/message-edit-focus.spec.ts",
+        "**/mention-picker.spec.ts",
         "**/team-mentions.spec.ts",
         "**/persistent-agent-audience.spec.ts",
         "**/relay-reconnect.spec.ts",

desktop/src/features/channels/hooks.ts

@@ -13,7 +13,6 @@ import {
   deleteChannel,
   getCanvas,
   getChannelDetails,
-  getChannelMembers,
   getChannels,
   hideDm,
   joinChannel,
@@ -49,11 +48,9 @@ import {
   type ChannelSnapshot,
   writeChannelSnapshot,
 } from "@/features/channels/channelSnapshot";
-import {
-  CHANNEL_MEMBERS_STALE_TIME_MS,
-  channelMembersQueryKey,
-} from "@/features/channels/rosterFreshness";
+import { channelMembersQueryKey } from "@/features/channels/rosterFreshness";
 import { dmVisibilityQueryKeyFor } from "@/features/channels/useHiddenDmIds";
+import { refreshDirectoryAfterMembershipChange } from "./membershipDirectorySync";
 
 export const channelsQueryKey = ["channels"] as const;
 /** Keeps focused polling at the established one-minute cadence. */
@@ -516,6 +513,7 @@ export function useCreateChannelMutation() {
       queryClient.setQueryData<Channel[]>(channelsQueryKey, (current) =>
         upsertCachedChannel(current, createdChannel),
       );
+      refreshDirectoryAfterMembershipChange(queryClient);
     },
     onSettled: () => {
       // refetchType "none": onSuccess already cached the relay-returned channel;
@@ -642,23 +640,7 @@ export function useChannelDetailsQuery(
   });
 }
 
-export function useChannelMembersQuery(
-  channelId: string | null,
-  enabled = true,
-) {
-  return useQuery({
-    enabled: enabled && channelId !== null,
-    queryKey: ["channels", channelId ?? "none", "members"],
-    queryFn: async () => {
-      if (!channelId) {
-        throw new Error("No channel selected.");
-      }
-
-      return getChannelMembers(channelId);
-    },
-    staleTime: CHANNEL_MEMBERS_STALE_TIME_MS,
-  });
-}
+export { useChannelMembersQuery } from "./useChannelMembersQuery";
 
 export function useUpdateChannelMutation(channelId: string | null) {
   const queryClient = useQueryClient();
@@ -841,6 +823,9 @@ export function useAddChannelMembersMutation(channelId: string | null) {
       return addChannelMembers({ ...rest, channelId: effectiveChannelId });
     },
     onSuccess: (result, variables) => {
+      if (result.added.length > 0) {
+        refreshDirectoryAfterMembershipChange(queryClient);
+      }
       const effectiveChannelId = variables.channelId ?? channelId;
       if (
         effectiveChannelId &&
@@ -896,6 +881,7 @@ export function useJoinChannelMutation(channelId: string | null) {
 
       await joinChannel(channelId);
     },
+    onSuccess: () => refreshDirectoryAfterMembershipChange(queryClient),
     onSettled: async () => {
       await invalidateChannelState(queryClient, channelId);
     },
@@ -913,6 +899,7 @@ export function useLeaveChannelMutation(channelId: string | null) {
 
       await leaveChannel(channelId);
     },
+    onSuccess: () => refreshDirectoryAfterMembershipChange(queryClient),
     onSettled: async () => {
       await invalidateChannelState(queryClient, channelId);
     },

desktop/src/features/channels/membershipDirectorySync.test.mjs

@@ -3,6 +3,7 @@ import { afterEach, test } from "node:test";
 import { QueryClient, QueryObserver } from "@tanstack/react-query";
 import {
   refreshDirectoryAfterMembershipChange as refresh,
+  refreshDirectoryForRosterChange as rosterChanged,
   resetMembershipDirectorySync,
 } from "./membershipDirectorySync.ts";
 
@@ -118,6 +119,34 @@ test("failed refresh ends in error and does not schedule a self-sustaining retry
   assert.equal(calls, 1);
 });
 
+test("only changed membership or agent classification refreshes; names and ordering do not", async () => {
+  const value = client();
+  let calls = 0;
+  observe(value, async () => {
+    calls += 1;
+    return [];
+  });
+  const person = { pubkey: "a".repeat(64), role: "member", isAgent: false };
+  const agent = { pubkey: "b".repeat(64), role: "member", isAgent: true };
+  rosterChanged(value, undefined, [person]);
+  rosterChanged(
+    value,
+    [person, agent],
+    [{ ...agent, displayName: "Renamed" }, person],
+  );
+  await settle();
+  assert.equal(calls, 0);
+  rosterChanged(value, [person], [person, agent]);
+  await settle();
+  assert.equal(calls, 1);
+  rosterChanged(value, [person, agent], [person]);
+  await settle();
+  assert.equal(calls, 2);
+  rosterChanged(value, undefined, [agent]);
+  await settle();
+  assert.equal(calls, 3);
+});
+
 test("community reset cancels queued work and event deduplication is client-scoped", async () => {
   const first = client();
   const second = client();

desktop/src/features/channels/membershipDirectorySync.ts

@@ -1,5 +1,8 @@
 import type { QueryClient } from "@tanstack/react-query";
 
+import type { ChannelMember } from "@/shared/api/types";
+import { normalizePubkey } from "@/shared/lib/pubkey";
+
 const directoryQueryKey = ["relay-agents"] as const;
 const COALESCE_MS = 200;
 const MAX_EVENT_IDS = 256;
@@ -78,3 +81,34 @@ export function refreshDirectoryAfterMembershipChange(
     });
   }, COALESCE_MS);
 }
+
+function membershipFingerprint(members: readonly ChannelMember[]): string {
+  return members
+    .map(
+      (member) =>
+        `${normalizePubkey(member.pubkey)}:${member.role ?? ""}:${member.isAgent === true}`,
+    )
+    .sort()
+    .join("|");
+}
+
+/**
+ * A later roster can observe a write that the acceptance-time directory read
+ * could not yet see. Refresh once for that semantic change, not for names,
+ * ordering, repeated snapshots, or every local store notification. An initial
+ * agent-bearing roster also repairs discovery when no previous roster exists.
+ */
+export function refreshDirectoryForRosterChange(
+  queryClient: QueryClient,
+  previous: readonly ChannelMember[] | undefined,
+  current: readonly ChannelMember[],
+): void {
+  if (
+    previous
+      ? membershipFingerprint(previous) === membershipFingerprint(current)
+      : !current.some((member) => member.isAgent || member.role === "bot")
+  ) {
+    return;
+  }
+  refreshDirectoryAfterMembershipChange(queryClient);
+}