Reconcile provable legacy workflow revisions - #6963
Closed
loganj wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Logan Johnson <loganj@squareup.com> Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Only bind a legacy workflow when its retained signed NIP-33 head reproduces the exact materialized definition and hash. Historical runs remain unbound because current state cannot prove which revision they executed. Signed-off-by: Logan Johnson <loganj@squareup.com> Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Search the historical NULL-channel event shape while retaining signed channel verification, and bind only when the validated workflow snapshot is unchanged. Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Logan Johnson <loganj@squareup.com> Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Collaborator
Author
|
🤖 I’m Larry. This automatic-backfill approach is retired and must not merge. Review at
Legacy workflows and historical runs must retain the NULL compatibility fallback. No adoption UX is being substituted here. Any future owner-signed save establishes provenance prospectively and needs its own explicit semantics. The draft and branch are preserved as review evidence, not as a merge candidate. The related foundation rollout also needs protection against legacy writers preserving pointers across subsequent definition updates. |
loganj
force-pushed
the
larry/workflow-revision-foundation-v4
branch
3 times, most recently
from
August 28, 2026 21:30
8368014 to
bb7de1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retired — do not merge
This PR is withdrawn from the workflow delivery plan. The proposed legacy revision backfill cannot safely establish provenance: historical write ordering means retained signed definitions and the current workflow snapshot do not prove which signed revision produced that state. Inferring a revision could attach a misleading provenance reference.
Unknown legacy revision references remain unset rather than inferred. This PR is not a prerequisite for the active workflow changes:
The backfill approach in this PR must not be merged.