Skip to content

fix(desktop): stop pulsing addressed agents on send #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
Aug 26, 2026
Merged

fix(desktop): stop pulsing addressed agents on send #6873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion desktop/src/features/messages/ui/MessageComposer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ function MessageComposerImpl({
drafts,
emojiAutocomplete,
mentions,
onAddressedAgentsSendStarted: addressPulse.pulseMany,
onAddressedAgentsComposerCleared: (pubkeys) =>
restoreAddressedAgentMentionsRef.current(pubkeys),
onAddressedAgentsSendFailed: addressPulse.shakeMany,
Expand Down
5 changes: 0 additions & 5 deletions desktop/src/features/messages/ui/useMentionSendFlow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export function useMentionSendFlow({
emojiAutocomplete,
mentions,
onPrepareSendChannel,
onAddressedAgentsSendStarted,
onAddressedAgentsComposerCleared,
onAddressedAgentsSendFailed,
onAddressedAgentsSendSucceeded,
Expand Down Expand Up @@ -404,9 +403,6 @@ export function useMentionSendFlow({
draft.capturedChannelId === channelIdRef.current ||
channelIdRef.current === null
) {
if (draft.addressedAgentPubkeys.length > 0) {
onAddressedAgentsSendStarted?.(draft.addressedAgentPubkeys);
}
clearComposer();
if (draft.addressedAgentPubkeys.length > 0) {
optimisticComposerContent =
Expand Down Expand Up @@ -640,7 +636,6 @@ export function useMentionSendFlow({
getManagedAgentsByPubkey,
mentions.isAgentPubkey,
mentions.revalidateMentionPubkeys,
onAddressedAgentsSendStarted,
onAddressedAgentsComposerCleared,
onAddressedAgentsSendFailed,
onAddressedAgentsSendSucceeded,
Expand Down
1 change: 0 additions & 1 deletion desktop/src/features/messages/ui/useMentionSendFlow.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export type UseMentionSendFlowOptions = {
emojiAutocomplete: Pick<UseEmojiAutocompleteResult, "clearEmojis">;
mentions: UseMentionsResult;
onPrepareSendChannel?: (pubkeys?: string[]) => Promise<string | null>;
onAddressedAgentsSendStarted?: (pubkeys: readonly string[]) => void;
onAddressedAgentsComposerCleared?: (pubkeys: readonly string[]) => string;
onAddressedAgentsSendFailed?: (pubkeys: readonly string[]) => void;
onAddressedAgentsSendSucceeded?: (
Expand Down
8 changes: 4 additions & 4 deletions desktop/tests/e2e/persistent-agent-audience.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ test("the mention button opens settings and can undo an address", async ({
).toHaveCount(0);
});

test("always-mentioned agents remain in the mention button while Enter-send resolves", async ({
test("always-mentioned agents remain selected without replaying their animation while Enter-send resolves", async ({
page,
}) => {
await installAudienceFixtures(page, {
Expand Down Expand Up @@ -549,7 +549,7 @@ test("always-mentioned agents remain in the mention button while Enter-send reso
.not.toContain("");
await expect(avatar).toHaveAttribute(
"data-pulse-version",
String(initialPulseVersion + 1),
String(initialPulseVersion),
{ timeout: 500 },
);
await expect(
Expand Down Expand Up @@ -587,7 +587,7 @@ test("always-mentioned agents remain in the mention button while Enter-send reso
).toHaveCount(1);
});

test("a failed always-mentioned send shakes the composer avatar", async ({
test("a failed always-mentioned send shakes the composer avatar without replaying its selection animation", async ({
page,
}) => {
await installAudienceFixtures(page, {
Expand All @@ -610,7 +610,7 @@ test("a failed always-mentioned send shakes the composer avatar", async ({

await expect(avatar).toHaveAttribute(
"data-pulse-version",
String(initialPulseVersion + 1),
String(initialPulseVersion),
{ timeout: 500 },
);
await expect(input).toHaveText("@Morgarita please retry");
Expand Down
Loading