fix(desktop): drop punctuation-only STT transcripts in huddles - #6497
Open
tlongwell-block wants to merge 1 commit into
Open
fix(desktop): drop punctuation-only STT transcripts in huddles#6497tlongwell-block wants to merge 1 commit into
tlongwell-block wants to merge 1 commit into
Conversation
Parakeet hallucinates bare punctuation ('.', '?') on non-speech audio
that clears the VAD's minimum-voiced-frames gate (12 frames / ~192 ms,
kept low to preserve short replies). Every downstream filter only
checked for emptiness, so a lone '.' was signed and posted as a real
kind:9 channel message, notifying every tagged agent.
Drop transcripts with no alphanumeric characters in send_transcript,
before they leave the STT worker. Real speech — including single-word
and non-ASCII replies — is unaffected.
Signed-off-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
Co-authored-by: Tyler <109685178+tlongwell-block@users.noreply.github.com>
tlongwell-block
commented
Aug 21, 2026
tlongwell-block
left a comment
tlongwell-block
left a comment
Collaborator
Author
There was a problem hiding this comment.
Independent review: clean at exact head c3b84b9. The boundary guard is minimal and Unicode-aware, preserves short valid replies, and the regression test correctly fails by assertion before the fix. I independently ran cd desktop/src-tauri && cargo test --workspace at this exact head with no failures. Verdict: approve. GitHub would not record an APPROVED state because this agent session authenticates as the PR author (Review Can not approve your own pull request).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stray
.messages appear in huddle channels (reported by Tyler in the tyler-agent-stuff huddle, 2026-08-21). Each one notifies every tagged agent for zero content.Chain:
MIN_VOICED_FRAMES = 12, ~192 ms) to preserve short replies like "yes" — so brief noise blips (breath, keyboard) can clear it.decode_speechtrims whitespace,send_transcriptchecked!text.is_empty(), and the posting task inpipeline.rscheckst.is_empty(). A lone.survives all three and is signed and posted as a kind:9 message.Fix
Drop transcripts containing no alphanumeric characters in
send_transcript, before they leave the STT worker. One guard clause + a comment. Real speech — including single-word ("yes") and non-ASCII ("привет", "第九") replies — is unaffected (char::is_alphanumericis Unicode-aware).Verification
punctuation_only_transcripts_are_droppedFAILS at pre-fix code (assertion shows.?!etc. flowing through) and passes with the fix — the instrument detects the bug it claims to fix.desktop/src-taurisuite at HEAD c3b84b9: 2725 passed / 0 failed (+7 +3 in other targets).Root-cause analysis and discussion in the tyler-agent-stuff huddle channel.