Skip to content

Revert "fix(acp): gate relay-signed workflow messages on their attributed author" - #6311

Merged
TheSentinel454 merged 1 commit into
mainfrom
revert-6129-fizz/workflow-wake-author-gate
Aug 19, 2026
Merged

Revert "fix(acp): gate relay-signed workflow messages on their attributed author"#6311
TheSentinel454 merged 1 commit into
mainfrom
revert-6129-fizz/workflow-wake-author-gate

Conversation

@TheSentinel454

@TheSentinel454 TheSentinel454 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Reverts #6129

@TheSentinel454
TheSentinel454 requested a review from a team as a code owner August 19, 2026 14:05
@TheSentinel454
TheSentinel454 enabled auto-merge (squash) August 19, 2026 14:15
@loganj loganj mentioned this pull request Aug 19, 2026
Open
@TheSentinel454
TheSentinel454 merged commit 08eb46e into main Aug 19, 2026
73 of 77 checks passed
@TheSentinel454
TheSentinel454 deleted the revert-6129-fizz/workflow-wake-author-gate branch August 19, 2026 15:28
wpfleger96 pushed a commit that referenced this pull request Aug 19, 2026
Duncan
Merge remote-tracking branch 'origin/main' into duncan/workflow-reply…
3a5e311 
…-in-thread

* origin/main: (32 commits)
  Revert "fix(acp): gate relay-signed workflow messages on their attributed author" (#6311)
  fix(desktop): morph the drawer panel icon instead of sliding it (#6306)
  feat(desktop): refine repository-aware project workspaces (#6003)
  Fix mobile Activity thread navigation (#5850)
  perf(desktop): parallelize relay agent directory rebuild (#6258)
  Refine the mobile emoji picker (#5853)
  fix(desktop): exclude archived agents from nest, order regeneration (#5905)
  Add font size and conversation density preferences (#5644)
  fix(desktop): emit camelCase config-write payload fields (#6062)
  fix(desktop): downscale large avatars for agent-share PNG body (#6260)
  fix(desktop): preserve early relay auth challenges (#3320)
  Polish mobile message actions (#5873)
  Refine mobile pairing confirmation (#6018)
  chore(scripts): add buzz-adopt-prod-agents.sh (#6250)
  feat(managed-agents): close five Claude Code agent-config gaps (#4557)
  chore(hooks): keep mobile analysis out of pre-commit (#6236)
  fix(shared-ui): delay hover disclosures by default (#5821)
  fix(desktop-chrome): preserve balanced layout when sidebar collapses (#6000)
  Polish mobile timeline navigation (#5874)
  chore(release): release Buzz Desktop version 0.5.17 (#6234)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
tellaho added a commit that referenced this pull request Aug 19, 2026
@tellaho Carl
Merge remote-tracking branch 'origin/main' into tho/workflow-editor-f…
a95b9bd 
…oundation

* origin/main:
  fix(desktop): hide archived channels from #/Tab autocomplete (#6156)
  Unify mobile channel details (#6113)
  Revert "fix(acp): gate relay-signed workflow messages on their attributed author" (#6311)
  fix(desktop): morph the drawer panel icon instead of sliding it (#6306)
  feat(desktop): refine repository-aware project workspaces (#6003)

Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>

# Conflicts:
#	desktop/src/app/AppShell.tsx
wpfleger96 pushed a commit that referenced this pull request Aug 19, 2026
Duncan
Merge remote-tracking branch 'origin/main' into wpfleger/deterministi…
08715a7 
…c-agent-commit-identity

* origin/main:
  Revert "fix(acp): gate relay-signed workflow messages on their attributed author" (#6311)
  fix(desktop): morph the drawer panel icon instead of sliding it (#6306)
  feat(desktop): refine repository-aware project workspaces (#6003)
  Fix mobile Activity thread navigation (#5850)
  perf(desktop): parallelize relay agent directory rebuild (#6258)
  Refine the mobile emoji picker (#5853)
  fix(desktop): exclude archived agents from nest, order regeneration (#5905)
  Add font size and conversation density preferences (#5644)
  fix(desktop): emit camelCase config-write payload fields (#6062)
  fix(desktop): downscale large avatars for agent-share PNG body (#6260)
  fix(desktop): preserve early relay auth challenges (#3320)
  Polish mobile message actions (#5873)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
wpfleger96 pushed a commit that referenced this pull request Aug 19, 2026
Duncan
Merge remote-tracking branch 'origin/main' into wpfleger/archive-rete…
84e61d4 
…ntion-phase1

* origin/main: (71 commits)
  Revert "fix(acp): gate relay-signed workflow messages on their attributed author" (#6311)
  fix(desktop): morph the drawer panel icon instead of sliding it (#6306)
  feat(desktop): refine repository-aware project workspaces (#6003)
  Fix mobile Activity thread navigation (#5850)
  perf(desktop): parallelize relay agent directory rebuild (#6258)
  Refine the mobile emoji picker (#5853)
  fix(desktop): exclude archived agents from nest, order regeneration (#5905)
  Add font size and conversation density preferences (#5644)
  fix(desktop): emit camelCase config-write payload fields (#6062)
  fix(desktop): downscale large avatars for agent-share PNG body (#6260)
  fix(desktop): preserve early relay auth challenges (#3320)
  Polish mobile message actions (#5873)
  Refine mobile pairing confirmation (#6018)
  chore(scripts): add buzz-adopt-prod-agents.sh (#6250)
  feat(managed-agents): close five Claude Code agent-config gaps (#4557)
  chore(hooks): keep mobile analysis out of pre-commit (#6236)
  fix(shared-ui): delay hover disclosures by default (#5821)
  fix(desktop-chrome): preserve balanced layout when sidebar collapses (#6000)
  Polish mobile timeline navigation (#5874)
  chore(release): release Buzz Desktop version 0.5.17 (#6234)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
jedwards27 added a commit to jedwards27/buzz that referenced this pull request Aug 19, 2026
@jedwards27
Merge remote-tracking branch 'origin/main' into feat/native-review-jo…
3101af6 
…urneys

* origin/main:
  chore: serialize mobile pre-push checks (block#6322)
  fix(buzz-acp): loosen workspace-scan guardrail to allow named paths (block#6261)
  fix(buzz-dev-mcp): expand leading ~ in read_file/str_replace paths (block#6271)
  perf(desktop): move five hot renderer paths from JS into Rust (block#6024)
  fix(media): accept portrait video resolutions (block#6058)
  fix(desktop): hide archived channels from #/Tab autocomplete (block#6156)
  Unify mobile channel details (block#6113)
  Revert "fix(acp): gate relay-signed workflow messages on their attributed author" (block#6311)
  fix(desktop): morph the drawer panel icon instead of sliding it (block#6306)
  feat(desktop): refine repository-aware project workspaces (block#6003)
  Fix mobile Activity thread navigation (block#5850)

Signed-off-by: Jude Edwards <judeedwards@squareup.com>
@arvesolland

arvesolland commented Aug 19, 2026

Copy link
Copy Markdown

Could you share the reason for this revert? The PR body is just "Reverts #6129" and I couldn't find a follow-up issue or re-land, so I'm unsure whether a regression was found or this was reverted for release timing.

Context for why I'm asking: we run a downstream fork and deployed #6129 to our staging relay yesterday. It fixed a real problem for us — scheduled workflow send_message actions were landing in the channel with correct p tags, but the mentioned agents never woke, because the events are signed with the relay keypair and author_allowed runs before the p-tag mention check. Under the default respond_to = owner-only every wake died at that gate, silently, at debug log level.

Since the revert restores that behaviour, we're deciding whether to carry #6129 as a downstream deviation or follow you back. If you hit a regression we'd rather know what it was than rediscover it. If it was timing and a re-land is planned, we'll just wait.

Happy to help test either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlongwell-block tlongwell-block tlongwell-block approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheSentinel454 @arvesolland @tlongwell-block