Skip to content

fix(desktop): align preview sidebar row styling - #6163

Merged
wesbillman merged 1 commit into
mainfrom
carl/sidebar-experiment-styling
Aug 17, 2026
Merged

fix(desktop): align preview sidebar row styling#6163
wesbillman merged 1 commit into
mainfrom
carl/sidebar-experiment-styling

Conversation

@wesbillman

@wesbillman wesbillman commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apply the inactive primary-navigation opacity treatment to every sidebar destination, including Pulse, Projects, and Workflows
  • remove the duplicated Inbox and Agents conditionals so future gated rows inherit the same hierarchy
  • add E2E coverage for all inactive rows and restoration to full opacity when selected

Validation

  • pnpm --dir desktop build:e2e
  • pnpm --dir desktop exec playwright test badge.spec.ts --grep "primary navigation rows share the same inactive emphasis" --project=smoke
  • pre-push hook: desktop check, typecheck, and 4,984 unit tests

@wesbillman Carl
fix(desktop): align preview sidebar row styling
3c20be1 
Apply the inactive primary-navigation emphasis at the menu level so gated
Pulse, Projects, and Workflows rows match Inbox and Agents. Cover all rows
and selected-state restoration in the sidebar badge E2E suite.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman
wesbillman requested a review from a team as a code owner August 17, 2026 20:09
wesbillman
wesbillman commented Aug 17, 2026
View reviewed changes

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review verdict: CLEAR at 3c20be1f5f7d289df403984e7b4176d9a2c67e3a.

  • Selector boundary is appropriately limited to direct icon/label children of inactive menu buttons inside .sidebar-primary-menu; badges and other sidebar menus are unaffected (components.css:6-8, AppSidebarPinnedHeader.tsx:104).
  • Active rows are excluded by :not([data-active="true"]), preserving full-opacity selected styling.
  • The E2E regression covers all five inactive rows and verifies selected-state restoration on a gated row (badge.spec.ts:108-140).

No material correctness, scope, or coverage findings.

@wesbillman
wesbillman merged commit 439c037 into main Aug 17, 2026
43 of 46 checks passed
@wesbillman
wesbillman deleted the carl/sidebar-experiment-styling branch August 17, 2026 21:49
wpfleger96 pushed a commit that referenced this pull request Aug 17, 2026
Duncan
Merge remote-tracking branch 'origin/main' into duncan/claude-config-…
a7ce9b8 
…gaps

* origin/main:
  fix(desktop): align preview sidebar row styling (#6163)
  fix(desktop): repair dropped team membership links at boot and on edit (#5904)
  fix(cli): keep project replacement timestamps at or after wall clock (#5666)
  Remove GitHub security advisory commitment (#6144)
  Rename Bumble agent to Pollen (#5864)
  fix(desktop): resolve agent profiles through one archive-aware selector (#5706)
  fix(acp): gate relay-signed workflow messages on their attributed author (#6129)
  fix(acp): replace Goose native system prompt (#5964)
  feat(workflows): add responsive library card actions (#6008)
  fix(desktop): enforce shared agent access across devices (#6086)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
morgmart added a commit that referenced this pull request Aug 18, 2026
@morgmart
Merge remote-tracking branch 'origin/main' into kennylopez-inter-typo…
f0a8ef9 
…graphy-staging

* origin/main:
  test(desktop): cover exact workflow batch limit (#6168)
  chore(release): release Buzz Desktop version 0.5.15 (#6173)
  Preserve managed agent mentions during relay errors (#6167)
  fix(workflows): preserve multi-channel listing semantics (#6009)
  Remove Startup Recovery section in base prompt (#6161)
  fix(desktop): align preview sidebar row styling (#6163)
  fix(desktop): repair dropped team membership links at boot and on edit (#5904)
  fix(cli): keep project replacement timestamps at or after wall clock (#5666)

Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
@adrienlacombe adrienlacombe mentioned this pull request Aug 18, 2026
Merged
wpfleger96 pushed a commit that referenced this pull request Aug 18, 2026
Duncan
Merge remote-tracking branch 'origin/main' into wpfleger/admin-api-be…
e7c9341 
…arer-auth

* origin/main: (21 commits)
  fix(desktop): bind presence retry timers (#6213)
  ci: make file-size policy a first-class gate (#6187)
  fix(desktop): eliminate mounted-view CPU burn — compositor-safe shimmer, observer append fast path, poll-tick disk reads (#6198)
  chore(release): release Buzz Desktop version 0.5.16 (#6191)
  fix(desktop): restore release agent mentions (#6182)
  test(desktop): cover exact workflow batch limit (#6168)
  chore(release): release Buzz Desktop version 0.5.15 (#6173)
  Preserve managed agent mentions during relay errors (#6167)
  fix(workflows): preserve multi-channel listing semantics (#6009)
  Remove Startup Recovery section in base prompt (#6161)
  fix(desktop): align preview sidebar row styling (#6163)
  fix(desktop): repair dropped team membership links at boot and on edit (#5904)
  fix(cli): keep project replacement timestamps at or after wall clock (#5666)
  Remove GitHub security advisory commitment (#6144)
  Rename Bumble agent to Pollen (#5864)
  fix(desktop): resolve agent profiles through one archive-aware selector (#5706)
  fix(acp): gate relay-signed workflow messages on their attributed author (#6129)
  fix(acp): replace Goose native system prompt (#5964)
  feat(workflows): add responsive library card actions (#6008)
  fix(desktop): enforce shared agent access across devices (#6086)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

# Conflicts:
#	CHANGELOG.md
tlongwell-block pushed a commit that referenced this pull request Aug 18, 2026
Wren
Merge origin/main into eva/js-to-rust-perf-pack
8f86588 
Co-authored-by: Wren <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@buzz.block.builderlab.xyz>
Signed-off-by: Wren <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@buzz.block.builderlab.xyz>

* origin/main:
  fix(desktop): bind presence retry timers (#6213)
  ci: make file-size policy a first-class gate (#6187)
  fix(desktop): eliminate mounted-view CPU burn — compositor-safe shimmer, observer append fast path, poll-tick disk reads (#6198)
  chore(release): release Buzz Desktop version 0.5.16 (#6191)
  fix(desktop): restore release agent mentions (#6182)
  test(desktop): cover exact workflow batch limit (#6168)
  chore(release): release Buzz Desktop version 0.5.15 (#6173)
  Preserve managed agent mentions during relay errors (#6167)
  fix(workflows): preserve multi-channel listing semantics (#6009)
  Remove Startup Recovery section in base prompt (#6161)
  fix(desktop): align preview sidebar row styling (#6163)
  fix(desktop): repair dropped team membership links at boot and on edit (#5904)

Signed-off-by: Wren <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@buzz.block.builderlab.xyz>
bhargavms pushed a commit to EWA-Services/buzz that referenced this pull request Aug 18, 2026
@wesbillman Carl @bhargavms
fix(desktop): align preview sidebar row styling (block#6163)
539a5f8 
## Summary

- apply the inactive primary-navigation opacity treatment to every
sidebar destination, including Pulse, Projects, and Workflows
- remove the duplicated Inbox and Agents conditionals so future gated
rows inherit the same hierarchy
- add E2E coverage for all inactive rows and restoration to full opacity
when selected

## Validation

- `pnpm --dir desktop build:e2e`
- `pnpm --dir desktop exec playwright test badge.spec.ts --grep "primary
navigation rows share the same inactive emphasis" --project=smoke`
- pre-push hook: desktop check, typecheck, and 4,984 unit tests

Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: bhargavms <bhargav.m@ewa-services.com>
sandro-sq added a commit that referenced this pull request Aug 18, 2026
@sandro-sq
Merge remote-tracking branch 'origin/main' into sandro/mesh-compute-view
00b4866 
* origin/main: (78 commits)
  Polish mobile timeline navigation (#5874)
  chore(release): release Buzz Desktop version 0.5.17 (#6234)
  fix(prompt): simplify pickup follow-through (#6186)
  fix(mcp): scope todo usage (#6216)
  fix(desktop): bound remote agent mention authorization (#6224)
  fix: bump h2 for RUSTSEC-2026-0258 (#6222)
  fix(desktop): bind presence retry timers (#6213)
  ci: make file-size policy a first-class gate (#6187)
  fix(desktop): eliminate mounted-view CPU burn — compositor-safe shimmer, observer append fast path, poll-tick disk reads (#6198)
  chore(release): release Buzz Desktop version 0.5.16 (#6191)
  fix(desktop): restore release agent mentions (#6182)
  test(desktop): cover exact workflow batch limit (#6168)
  chore(release): release Buzz Desktop version 0.5.15 (#6173)
  Preserve managed agent mentions during relay errors (#6167)
  fix(workflows): preserve multi-channel listing semantics (#6009)
  Remove Startup Recovery section in base prompt (#6161)
  fix(desktop): align preview sidebar row styling (#6163)
  fix(desktop): repair dropped team membership links at boot and on edit (#5904)
  fix(cli): keep project replacement timestamps at or after wall clock (#5666)
  Remove GitHub security advisory commitment (#6144)
  ...

Signed-off-by: Alessandro Joabar <sandro@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesbillman