Skip to content

test(desktop): await channel E2E bridge readiness - #5886

Merged
wesbillman merged 1 commit into
mainfrom
carl/fix-channel-description-smoke
Aug 14, 2026
Merged

test(desktop): await channel E2E bridge readiness#5886
wesbillman merged 1 commit into
mainfrom
carl/fix-channel-description-smoke

Conversation

@wesbillman

@wesbillman wesbillman commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • wait for the channel mutation and cache invalidation E2E hooks before using them
  • make those hooks required after readiness instead of silently skipping fixture setup
  • keep the production channel settings behavior and assertion unchanged

Why

On slower CI startup, page.goto() can resolve before the E2E bridge installs its globals. The test used optional calls, so all three fixture operations could silently do nothing and leave the seeded General discussion for everyone description in React Query. The assertion then failed deterministically, including both retries.

Validation

At commit 5b4d5d290b316db5eef78c3596a17c7a270c8163:

  • pnpm -C desktop build:e2e
  • focused Playwright test repeated 30 times: 30 passed
  • pnpm -C desktop exec biome check tests/e2e/channels.spec.ts
  • mandatory pre-push hooks passed on the exact pushed head: branch-skew, desktop-check, desktop-typecheck, mobile-test, desktop-test, rust-tests, and desktop-tauri-checks
  • git diff --check origin/main...HEAD

@wesbillman Carl
test(desktop): await channel E2E bridge readiness
5b4d5d2 
The smoke test could call optional bridge hooks before the E2E bridge was
installed on slower CI startup, silently skipping its fixture mutations.
Wait for both hooks and invoke them as required setup before asserting the
channel settings UI.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman
wesbillman requested a review from a team as a code owner August 14, 2026 17:02
@wesbillman
wesbillman merged commit dbee291 into main Aug 14, 2026
24 checks passed
@wesbillman
wesbillman deleted the carl/fix-channel-description-smoke branch August 14, 2026 17:29
tlongwell-block pushed a commit that referenced this pull request Aug 14, 2026
Eva
Merge origin/main into bench/gepa-loop (branch-skew hook)
43e999b 
Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
Signed-off-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>

* origin/main: (67 commits)
  Projects v3: unify sharing, discussions, and issue ownership (#5792)
  chore(release): release Buzz Desktop version 0.5.12 (#5903)
  fix(mobile): unwrap batched observer telemetry (#5805)
  perf(desktop): update active turns incrementally (#5897)
  fix(link-previews): send while previews finish in background (#5697)
  fix(desktop): cut steady-state relay traffic from polls and read-state echo (#5879)
  fix(desktop): support channel message path links (#5889)
  feat(mobile-messages): render compact Buzz permalink chips (#5639)
  test(desktop): await channel E2E bridge readiness (#5886)
  fix(link-preview): refetch a link when it re-enters the composer (#5510)
  feat(desktop-messages): render compact Buzz permalink chips (#5638)
  Fix video comment effect wrapping (#5748)
  Teach agents to inherit Buzz product intent (#5875)
  feat(desktop): one relative date ladder across chat and the Inbox (#3769)
  fix(desktop): amortize observer journal eviction with a low-water mark (#5808)
  Unify agent profile content (#5788)
  Standardize settings section layout (#5855)
  fix(desktop): share one timer across same-interval useNow consumers (#5861)
  Clarify immediate spoken huddle replies (#5863)
  Scope desktop presence subscriptions to active demand (#5830)
  ...

Signed-off-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
wpfleger96 pushed a commit that referenced this pull request Aug 14, 2026
Duncan
Merge remote-tracking branch 'origin/main' into duncan/model-capabili…
b251ec4 
…ties-manifest

* origin/main: (35 commits)
  chore(release): release Buzz Desktop version 0.5.12 (#5903)
  fix(mobile): unwrap batched observer telemetry (#5805)
  perf(desktop): update active turns incrementally (#5897)
  fix(link-previews): send while previews finish in background (#5697)
  fix(desktop): cut steady-state relay traffic from polls and read-state echo (#5879)
  fix(desktop): support channel message path links (#5889)
  feat(mobile-messages): render compact Buzz permalink chips (#5639)
  test(desktop): await channel E2E bridge readiness (#5886)
  fix(link-preview): refetch a link when it re-enters the composer (#5510)
  feat(desktop-messages): render compact Buzz permalink chips (#5638)
  Fix video comment effect wrapping (#5748)
  Teach agents to inherit Buzz product intent (#5875)
  feat(desktop): one relative date ladder across chat and the Inbox (#3769)
  fix(desktop): amortize observer journal eviction with a low-water mark (#5808)
  Unify agent profile content (#5788)
  Standardize settings section layout (#5855)
  fix(desktop): share one timer across same-interval useNow consumers (#5861)
  Clarify immediate spoken huddle replies (#5863)
  Scope desktop presence subscriptions to active demand (#5830)
  Polish mobile profiles, DMs, and sheets (#5401)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
wpfleger96 pushed a commit that referenced this pull request Aug 14, 2026
Duncan
Merge remote-tracking branch 'origin/main' into wpfleger/admin-api-be…
64f6ebe 
…arer-auth

* origin/main: (34 commits)
  fix(ci): read Playwright version without nested shell quoting (#5910)
  fix(desktop): restore the agent trading-card mint button (#5900)
  Projects v3: unify sharing, discussions, and issue ownership (#5792)
  chore(release): release Buzz Desktop version 0.5.12 (#5903)
  fix(mobile): unwrap batched observer telemetry (#5805)
  perf(desktop): update active turns incrementally (#5897)
  fix(link-previews): send while previews finish in background (#5697)
  fix(desktop): cut steady-state relay traffic from polls and read-state echo (#5879)
  fix(desktop): support channel message path links (#5889)
  feat(mobile-messages): render compact Buzz permalink chips (#5639)
  test(desktop): await channel E2E bridge readiness (#5886)
  fix(link-preview): refetch a link when it re-enters the composer (#5510)
  feat(desktop-messages): render compact Buzz permalink chips (#5638)
  Fix video comment effect wrapping (#5748)
  Teach agents to inherit Buzz product intent (#5875)
  feat(desktop): one relative date ladder across chat and the Inbox (#3769)
  fix(desktop): amortize observer journal eviction with a low-water mark (#5808)
  Unify agent profile content (#5788)
  Standardize settings section layout (#5855)
  fix(desktop): share one timer across same-interval useNow consumers (#5861)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

# Conflicts:
#	CHANGELOG.md
This was referenced Aug 17, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesbillman