feat(cli): include display names in channel members - #4461
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
|
looking at this for #4437 — if you're joining display names via users bulk on the same pubkeys from the membership event, that matches how the relay does mention routing. please keep display_name nullable when a profile is missing so tooling can tell "no name" from "not returned". |
|
Thanks, that is the contract in this branch now. |
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
|
The nullable |
Summary
buzz channels membersserialized the channel membership tags directly, so each record contained onlypubkeyandrole. This change loads member profiles with one batched kind:0 filter and adds a nullabledisplay_nameto each record while preserving membership order and roles. The profile projection uses the relay's existingnamefallback; missing or malformed profiles producenull.Related issue
Fixes #4437. No duplicate implementation was found; the closest prior CLI mention work is #3330, which does not change
channels membersoutput.Testing
cargo test -p buzz-cli channel_member -- --nocapturecargo test -p buzz-clicargo clippy -p buzz-cli --all-targets --all-features -- -D warningscargo fmt --all -- --checkjust ciAll checks passed. No screenshots are needed for this CLI JSON change.