Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 43 additions & 2 deletions crates/buzz-sdk/src/builders.rs
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,9 @@ pub fn build_add_member(
if let Some(r) = role {
tags.push(tag(&["role", r.as_str()])?);
}
Ok(EventBuilder::new(Kind::Custom(9000), "").tags(tags))
Ok(EventBuilder::new(Kind::Custom(9000), "")
.tags(tags)
.allow_self_tagging())
}

/// Build a NIP-29 remove-member event (kind 9001).
Expand All @@ -588,7 +590,9 @@ pub fn build_remove_member(
tag(&["h", &channel_id.to_string()])?,
tag(&["p", &target_pubkey.to_ascii_lowercase()])?,
];
Ok(EventBuilder::new(Kind::Custom(9001), "").tags(tags))
Ok(EventBuilder::new(Kind::Custom(9001), "")
.tags(tags)
.allow_self_tagging())
}

/// Build a NIP-29 leave-request event (kind 9022).
Expand Down Expand Up @@ -2398,6 +2402,43 @@ mod tests {
assert!(has_tag(&ev, "p", pubkey));
}

#[test]
fn remove_member_self_referential_preserves_p_tag() {
// Regression test for #4326: nostr 0.44 strips p-tags whose value
// equals the signer's pubkey unless `.allow_self_tagging()` is set.
let cid = uuid();
let signer = keys();
let signer_pubkey_hex = signer.public_key().to_hex();
let ev = build_remove_member(cid, &signer_pubkey_hex)
.unwrap()
.sign_with_keys(&signer)
.expect("sign");
assert_eq!(ev.kind.as_u16(), 9001);
assert!(
has_tag(&ev, "p", &signer_pubkey_hex),
"p tag targeting the signer must survive signing"
);
assert!(has_tag(&ev, "h", &cid.to_string()));
}

#[test]
fn add_member_self_referential_preserves_p_tag() {
// Same self-referential guarantee as remove_member (#4326).
let cid = uuid();
let signer = keys();
let signer_pubkey_hex = signer.public_key().to_hex();
let ev = build_add_member(cid, &signer_pubkey_hex, Some(MemberRole::Member))
.unwrap()
.sign_with_keys(&signer)
.expect("sign");
assert_eq!(ev.kind.as_u16(), 9000);
assert!(
has_tag(&ev, "p", &signer_pubkey_hex),
"p tag targeting the signer must survive signing"
);
assert!(has_tag(&ev, "role", "member"));
}

#[test]
fn leave_happy_path() {
let cid = uuid();
Expand Down