Skip to content

fix(desktop): remove 880px reading cap in focus-mode thread #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
treywood wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(desktop): remove 880px reading cap in focus-mode thread #4007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions desktop/src/features/channels/lib/threadFocusLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,6 @@
*/
export const THREAD_FOCUS_SLIVER_WIDTH_PX = 72;

/**
* Max width of the centered message column inside the focus drawer.
*
* The drawer itself spans nearly the whole channel content area, but message
* text set that wide is unreadable. The list and composer share this max width
* with auto horizontal margins so the reading measure stays comfortable no
* matter how wide the window gets.
*/
export const THREAD_FOCUS_COLUMN_MAX_WIDTH_PX = 880;

/**
* Horizontal distance the focus drawer travels on enter/exit.
*
Expand Down
7 changes: 4 additions & 3 deletions desktop/src/features/channels/lib/threadPanelLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import type * as React from "react";

import { THREAD_FOCUS_COLUMN_MAX_WIDTH_PX } from "@/features/channels/lib/threadFocusLayout";

export type ThreadPanelLayoutProps = {
columnMaxWidthPx?: number;
headerLeading?: React.ReactNode;
Expand All @@ -27,7 +25,10 @@ export function getThreadPanelLayout({
}: ThreadPanelLayoutOptions): ThreadPanelLayoutProps {
return isFocusDrawer
? {
columnMaxWidthPx: THREAD_FOCUS_COLUMN_MAX_WIDTH_PX,
// Full-bleed to the drawer edge, matching split/channel/inbox views:
// an undefined max width drops both the reading-measure cap and the
// `mx-auto`/inline-gutter column treatment (see THREAD_PANEL_COLUMN_CLASS).
columnMaxWidthPx: undefined,
headerLeading,
isFocusMode: true,
isSinglePanelView: true,
Expand Down
Loading