Skip to content

Fix community profile onboarding back navigation #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 1 commit into from
Jul 18, 2026
Merged

Fix community profile onboarding back navigation #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions desktop/src/features/onboarding/ui/CommunityOnboardingFlow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,16 +334,6 @@ export function CommunityOnboardingFlow({
>
Next
</Button>
<Button
className="h-9 rounded-full bg-foreground/10 px-6 hover:bg-foreground/15"
data-testid="community-profile-back"
disabled={isPending || isUploadingAvatar}
onClick={clear}
type="button"
variant="ghost"
>
Back
</Button>
</OnboardingFooter>
</>
)
Expand Down
13 changes: 4 additions & 9 deletions desktop/tests/e2e/onboarding.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ test("first-community shows the scenario cards for localhost", async ({
).toBeVisible();
});

test("first-community profile step uses onboarding Next and Back controls", async ({
test("connected first-community profile step cannot discard resumable onboarding", async ({
page,
}) => {
await seedActiveIdentity(page, BLANK_TYLER_IDENTITY);
Expand All @@ -786,6 +786,7 @@ test("first-community profile step uses onboarding Next and Back controls", asyn
stage: "profile",
relayUrl: "wss://default.example.com",
communityName: "Default",
communityId: "e2e-default-community",
createdAt: timestamp,
updatedAt: timestamp,
}),
Expand All @@ -799,7 +800,6 @@ test("first-community profile step uses onboarding Next and Back controls", asyn
await installMockBridge(page, undefined, {
relayWsUrl: "wss://default.example.com",
skipOnboardingSeed: true,
skipCommunitySeed: true,
});
await page.goto("/");

Expand Down Expand Up @@ -858,20 +858,15 @@ test("first-community profile step uses onboarding Next and Back controls", asyn
).toBe(true);
await expect(page.getByTestId("community-profile-next")).toHaveText("Next");
await expect(page.getByTestId("community-profile-next")).toBeDisabled();
await expect(page.getByTestId("community-profile-back")).toHaveText("Back");

await page.getByTestId("community-profile-back").click();
await expect(
page.getByRole("button", { name: "Add me to a community" }),
).toBeVisible();
await expect(page.getByTestId("community-profile-back")).toHaveCount(0);
await expect
.poll(() =>
page.evaluate(
(key) => window.localStorage.getItem(key),
COMMUNITY_ONBOARDING_TRANSACTION_STORAGE_KEY,
),
)
.toBeNull();
.not.toBeNull();
});

test("identity fallback text does not count as a real onboarding name", async ({
Expand Down
Loading