Skip to content

fix(desktop): render lightbox image sharply at full resolution #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpfleger96 merged 2 commits into from
Jun 22, 2026
Merged

fix(desktop): render lightbox image sharply at full resolution #1181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a637558
fix(desktop): render lightbox image at full resolution
Jun 22, 2026
de4eb15
fix(desktop): demote settled lightbox layer for sharp rasterization
Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions desktop/src/shared/ui/markdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,10 +814,23 @@ function ImageZoomOverlay({
const isOpen = phase === "open";
const isFading = phase === "fading";
const displayBox = imageLightboxZoomBox(targetBox, zoom);
const transform =
prefersReducedMotion || isOpen
? imageLightboxTransform(sourceBox, displayBox)
: "translate3d(0, 0, 0) scale(1)";
// Once fully settled at 1x, drop the transform to `none` so the wrapper
// leaves the GPU-composited path and the <img> repaints through WebKit's
// high-quality paint rasterizer — matching inline-image sharpness. An
// identity `translate3d` would keep it composited, so it must be `none`.
const atRest =
isOpen &&
hasEntered &&
zoom === IMAGE_LIGHTBOX_MIN_ZOOM &&
// Holds composited through the trackpad gesture-end idle window: after a
// pinch settles back to exactly 1x, `isAdjustingZoom` stays true for
// IMAGE_LIGHTBOX_TRACKPAD_ZOOM_IDLE_MS, avoiding a demote/re-promote thrash.
!isAdjustingZoom;
const transform = atRest
? "none"
: prefersReducedMotion || isOpen
? imageLightboxTransform(targetBox, displayBox)
: imageLightboxTransform(targetBox, sourceBox);
const imageTransitionDuration = prefersReducedMotion
? IMAGE_LIGHTBOX_REDUCED_MOTION_MS
: isClosing
Expand Down Expand Up @@ -919,15 +932,22 @@ function ImageZoomOverlay({
}}
/>
<div
className="absolute z-10 origin-top-left overflow-visible transition-[opacity,transform] will-change-transform"
className={cn(
"absolute z-10 origin-top-left overflow-visible transition-[opacity,transform]",
// Only promote to a composited layer while animating; demoting at
// rest is what restores high-quality rasterization.
!atRest && "will-change-transform",
)}
style={{
...imageLightboxStyle(sourceBox),
...imageLightboxStyle(targetBox),
opacity: prefersReducedMotion && isClosing ? 0 : 1,
transform,
transitionDuration: `${imageTransitionDuration}ms`,
transitionProperty: prefersReducedMotion
? "opacity"
: "opacity, transform",
// At rest, exclude `transform` from the transition so the swap to
// `none` is instantaneous — a transitioned transform-to-`none` is
// browser-inconsistent and can flash at the settle.
transitionProperty:
prefersReducedMotion || atRest ? "opacity" : "opacity, transform",
transitionTimingFunction: isClosing
? IMAGE_LIGHTBOX_EASE_IN_OUT
: IMAGE_LIGHTBOX_EASE_OUT,
Expand Down