feat: implement long-running server with graceful shutdown #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
verbotenj
commented
Sep 25, 2025
verbotenj
commented
- Implement error aggregation in pipeline stop operations
- Add proper goroutine lifecycle management with sync primitives
- Prevent pipeline restart after stop using channel state
- Run error handling in background to maintain server operation
- Add non-blocking channel operations to prevent deadlocks
- Continus Adder running on multiple pipeline errors until SIGTERM or SIGINT received
- Implement error aggregation in pipeline stop operations - Add proper goroutine lifecycle management with sync primitives - Prevent pipeline restart after stop using channel state - Run error handling in background to maintain server operation - Add non-blocking channel operations to prevent deadlocks - Continus Adder running on multiple pipeline errors until SIGTERM or SIGINT received Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
fix/potential-concurrency-issues
branch
from
9d6938d to
c9667b2
Compare
wolf31o2
reviewed
Sep 25, 2025
| for idx, filter := range p.filters { | ||
| if err := filter.Start(); err != nil { | ||
| return fmt.Errorf("failed to start input: %w", err) | ||
| return fmt.Errorf("failed to start filter: %w", err) |
wolf31o2
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.