feat: add QRcode generate to scan it with snek mobile #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verbotenj
force-pushed
the
feat-show-qr-code
branch
2 times, most recently
from
d1fee38 to
521692f
Compare
agaffney
reviewed
Oct 23, 2023
There was a problem hiding this comment.
This relies on running snek from its code directory, which isn't a reasonable requirement for the end-user.
We should add some magic to read the template files at build time and compile the content into the binary, or at least hard-code something for now with only a single template file.
api/api.go
Outdated
| if err != nil { | ||
| logging.GetLogger().Errorf("Error finding project root: %v", err) | ||
| } | ||
| g.LoadHTMLGlob("" + rootDir + "/templates/*") |
There was a problem hiding this comment.
This will only work when running snek from the source repo
api/api.go
Outdated
| } | ||
| dir = nextDir | ||
| } | ||
| } |
There was a problem hiding this comment.
We probably don't want to do anything within snek that expects the original source repo.
api/api_test.go
Outdated
| func TestRouteRegistration(t *testing.T) { | ||
|
|
||
| dir, _ := os.Getwd() | ||
| fmt.Println(dir) |
There was a problem hiding this comment.
Do we still need this? It looks like it was here for debugging
Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat-show-qr-code
branch
from
521692f to
cac1f86
Compare
agaffney
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QRcode in browser
Closes #98