-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Hostname As ID #205
Closed
Closed
Use Hostname As ID #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When managing a larger cluster and wanting to take down specific hosts or chunks, is it quite inconvenient to find out the specific IDs handed out to servers in scalelite. Being able to use the domain names instead would be much nicer. While it is conceivable that multiple servers share the same domain name, this is actually pretty unlikely. Usually, the domain name should be unique and work just fine as identifier. This patch switches to using the domain name as identifier by default. If required for any reason, people can still switch to using UUIDs though. Old IDs will, of course, stay valid.
lkiesow
added a commit
to lkiesow/scalelite
that referenced
this pull request
Jul 26, 2020
This patch allows all commands to accept not only an exact ID match but also search patterns for matching URLs. This allows for a much easier control of groups of servers instead of having to find out the servers identifier every time and then handle each server indivifually. For example, you can run the following command to enbale multiple servers: ./bin/rake 'servers:enable[bbb0\[1-5\].lkiesow.io]' You can still use exact identifier matches though and the identifiers will always be checked before checking the URL. Hence, you still can use a command like: ./bin/rake 'servers:disable[a18201ec-f090-4bff-aaac-d0f5ab003f42]' This closes blindsidenetworks#205 which was trying to solve the same problem by using the host manes as server identifier instead. That shouldn't be necessary any longer when this patch is applied.
lkiesow
added a commit
to lkiesow/scalelite
that referenced
this pull request
Jul 26, 2020
This patch allows all commands to accept not only an exact ID match but also search patterns for matching URLs. This allows for a much easier control of groups of servers instead of having to find out the servers identifier every time and then handle each server indivifually. For example, you can run the following command to enbale multiple servers: ./bin/rake 'servers:enable[bbb0\[1-5\].lkiesow.io]' You can still use exact identifier matches though and the identifiers will always be checked before checking the URL. Hence, you still can use a command like: ./bin/rake 'servers:disable[a18201ec-f090-4bff-aaac-d0f5ab003f42]' This closes blindsidenetworks#205 which was trying to solve the same problem by using the host manes as server identifier instead. That shouldn't be necessary any longer when this patch is applied.
This was referenced Mar 1, 2021
Closing this in favour of #470 |
lkiesow
added a commit
to lkiesow/scalelite
that referenced
this pull request
Mar 1, 2021
This patch allows all commands to accept not only an exact ID match but also search patterns for matching URLs. This allows for a much easier control of groups of servers instead of having to find out the servers identifier every time and then handle each server indivifually. For example, you can run the following command to enbale multiple servers: ./bin/rake 'servers:enable[bbb0\[1-5\].lkiesow.io]' You can still use exact identifier matches though and the identifiers will always be checked before checking the URL. Hence, you still can use a command like: ./bin/rake 'servers:disable[a18201ec-f090-4bff-aaac-d0f5ab003f42]' This closes blindsidenetworks#205 which was trying to solve the same problem by using the host manes as server identifier instead. That shouldn't be necessary any longer when this patch is applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When managing a larger cluster and wanting to take down specific hosts
or chunks, is it quite inconvenient to find out the specific IDs handed
out to servers in scalelite. Being able to use the domain names instead
would be much nicer.
While it is conceivable that multiple servers share the same domain
name, this is actually pretty unlikely. Usually, the domain name should
be unique and work just fine as identifier.
This patch switches to using the domain name as an identifier by default.
If required for any reason, people can still switch to using UUIDs
though. Old IDs will, of course, stay valid.
Example: