Skip to content

Fix REASON_* constant compatibility - #12

Closed
ABuffEr wants to merge 1 commit into
blindpandas:masterfrom
ABuffEr:fix2021.1
Closed

ABuffEr wants to merge 1 commit into
blindpandas:masterfrom
ABuffEr:fix2021.1

Conversation

@ABuffEr

@ABuffEr ABuffEr commented Feb 21, 2021 •

Copy link
Copy Markdown

Hi,
I introduced a bridge-constant in unspoken/init.py, to guarantee compatibility with old and new version of NVDA, after the breaking changes in incoming 2021.1.
Updated lastTestedNVDAVersion accordingly.
I'm avoiding to distribute the modified version, even if some users are requesting it. So I'll be happy if you release a new updated version :)
This is my first pr, I hope I have done all without errors.

@mush42

mush42 commented Feb 22, 2021

Copy link
Copy Markdown
Collaborator

Hi @ABuffEr

Thanks for the PR. I'll review it as soon as possible.

Regards,

@SeanTolstoyevski

Copy link
Copy Markdown

i tried this.
but roles are not deleted.
everything works great but it have a problem, I don't know.

@tmthywynn8

Copy link
Copy Markdown

@ABuffEr, in the what's new document for 2021.1, one of the changes for developers reads:
sayAllHandler has been moved to speech.sayAll. (#12251)

Is there anyway to account for that change as well but still make it backwards compatible?

@ABuffEr

ABuffEr commented Sep 16, 2021

Copy link
Copy Markdown
Author

Is there anyway to account for that change as well but still make it backwards compatible?

Hi @tmthywynn8 ,
I don't know for this add-on specifically, but in general you can make an import like this:

try:
	import sayAllHandler as SAH
except ImportError:
	import speech.sayAll as SAH

then rename all old sayAllHandler occurrences with SAH.

@mush42

mush42 commented Sep 18, 2021

Copy link
Copy Markdown
Collaborator

Hi @ABuffEr

The minimum supported NVDA version for v7.0 is 2021.2. I've fixed the issue addressed by this PR.

@mush42 mush42 closed this Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants