Disk stats computation bug fix #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Thejas-bhat
commented
Aug 4, 2022
Thejas-bhat
commented
- Refactored the code with respect to disk stats computation, mainly the adding of chunks in content and int coders for location and doc values based information.
- Addressed a bug which was basically with respect to interim object maintaining state across New() calls.
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey and
sreekanth-cb
abhinavdangeti
approved these changes
Aug 5, 2022
sreekanth-cb
reviewed
Aug 5, 2022
Thejas-bhat
force-pushed
the
diskStatsBug
branch
from
24d118b to
9cc98ba
Compare
Thejas-bhat
force-pushed
the
diskStatsBug
branch
from
9cc98ba to
251a98a
Compare
sreekanth-cb
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.