Skip to content

Conversation

@mschoch
Copy link
Contributor

@mschoch mschoch commented Feb 1, 2019

When the batches passed to bleve are empty, this was a special
case that inadvertently avoided proper synchronization, and
led to the race detector to correctly point out that resetting
the batch was unsafe. By simply avoiding an unnecessary step
when the batch is empty, we can avoid the problem.

When the batches passed to bleve are empty, this was a special
case that inadvertently avoided proper synchronization, and
led to the race detector to correctly point out that resetting
the batch was unsafe.  By simply avoiding an unnecessary step
when the batch is empty, we can avoid the problem.
@steveyen
Copy link
Contributor

steveyen commented Feb 1, 2019

very cool -- good find & fix! looks good

@mschoch mschoch merged commit d3c9a28 into blevesearch:master Feb 1, 2019
This was referenced Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants