build(deps): bump actions/checkout from 4 to 6 - #4
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 51 51
Lines 1408 1408
Branches 235 235
=======================================
Hits 1267 1267
Misses 74 74
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dependabot
Bot
force-pushed
the
dependabot/github_actions/actions/checkout-6
branch
2 times, most recently
from
April 29, 2026 19:39
cdd9e10 to
93bf996
Compare
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/actions/checkout-6
branch
from
April 29, 2026 19:43
93bf996 to
c299f11
Compare
blehnen
added a commit
that referenced
this pull request
May 6, 2026
3 of 4 nitpicks fixed (all marked "💤 Low value" / informational; not blocking):
1. **Doods2ValidatorTests.cs Test 1** — tighten the threshold-encoding
regression assertion. `body.Should().Contain("\"*\":50")` could
accidentally false-match on `"*":500` or `"*":50.5`. Anchored to a JSON
delimiter via regex: `MatchRegex("\"\\*\"\\s*:\\s*50(?=[,}\\s])")`.
2. **RESEARCH.md §3.4 DOODS2 config example** — removed the redundant
`"Transport": "Http"` field (DOODS2 v2 is HTTP-only post-reversal). Also
bumped the example BaseUrl port from 8080 → 10200 to match the canonical
DOODS2 v2 default.
3. **RESEARCH.md §8 test-count table** — updated PR-2 row from "12 (HTTP +
gRPC)" to "9 HTTP-only" with reversal pointer to PLAN-2.3.md. Adjusted
cumulative totals to match the gRPC-reverted reality.
Punted #4 (centralize HttpClient config in `AddHttpClient(name, (sp, client) =>
...)` rather than mutating BaseAddress/Timeout in the keyed-singleton factory):
the same critique applies to CPAI + Roboflow registrars on main. Apply
atomically to all three in a v1.2.x cleanup commit, not just DOODS2.
Build clean (0 warnings); 267/267 tests still passing.
blehnen
added a commit
that referenced
this pull request
May 6, 2026
… factory) CodeRabbit nitpick #4 from PR #43: HttpClient.BaseAddress + Timeout are mutated inside the AddKeyedSingleton factory in all three validator registrars (CPAI, Roboflow, DOODS2) rather than configured at AddHttpClient registration time. Works today, but fragile if anyone later adds ConfigureHttpClient upstream. Deferred to a v1.2.x cleanup commit so all three registrars get the fix atomically — applying to DOODS2 only would create inconsistency. No code changes; just an ISSUES.md entry so the architect picks it up at next plan time.
blehnen
added a commit
that referenced
this pull request
May 11, 2026
Closes the 10 actionable findings from CodeRabbit on PR #46: - Extract canonical `StaticOptionsMonitor<T>` to `tests/FrigateRelay.TestHelpers/` and delete six per-file copies (`StaticMonitor<T>` / `StaticOptionsMonitor<T>`) scattered across the Host test suite. Subsumes the simplifier's deferred Phase 17 cleanup. Resolves CR #4, #5, #6. - Use named `metricsTagWriter:` argument at every downstream call site for `EventPump` and `ChannelActionDispatcher` (mirrors `snapshotResolver:` style; guideline: new required-leading params get named args). Resolves CR #2. - Add `Lock`-based synchronization to `CapturingLogger<T>.Entries` add path and `WaitForEntriesAsync` count read — closes a latent races where pump background-thread writes could corrupt the `List<T>` backing field while a test's poll-loop reads from the test thread. Resolves CR #3. - Hoist `normalizedCamera` local in `ChannelActionDispatcher` exception handler so the second `IncrementExhausted` / `IncrementActionsFailed` call reuses the first allocation. Cold path, but free win. Resolves CR #1. - `using var sp` on every `ServiceProvider` in `CodeProjectAiPluginRegistrarTests` so HttpClientFactory + logging are disposed between test methods. Resolves CR #7. - Fix README.md observability link to include the `#bounding-camera-tag-cardinality-otelmetricstagsknowncameras-v130` anchor on the href side (was only in the link text). Resolves CR #8. - Escape the regex pipe inside the inline-code span at `.shipyard/phases/16/VERIFICATION.md:44` so the markdown table doesn't see it as a column delimiter. Resolves CR #9. - Correct `.shipyard/phases/16/results/SIMPLIFICATION-16.md` subtitle from the stale "parallel validators" (Phase 14 scope) to the actual Phase 16 scope. Resolves CR #10. Verification: - `dotnet build FrigateRelay.sln -c Release` — 0 warnings, 0 errors. - Full unit suite (`.github/scripts/run-tests.sh --skip-integration`): 313/313 pass across all 10 test projects. - Host.Tests: 154/154 (was 154 pre-fix; no regression). - CodeProjectAi.Tests: 13/13. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 4 to 6.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
de0fac2Fix tag handling: preserve annotations and explicit fetch-tags (#2356)064fe7fAdd orchestration_id to git user-agent when ACTIONS_ORCHESTRATION_ID is set (...8e8c483Clarify v6 README (#2328)033fa0dAdd worktree support for persist-credentials includeIf (#2327)c2d88d3Update all references from v5 and v4 to v6 (#2314)1af3b93update readme/changelog for v6 (#2311)71cf226v6-beta (#2298)069c695Persist creds to a separate file (#2286)ff7abcdUpdate README to include Node.js 24 support details and requirements (#2248)08c6903Prepare v5.0.0 release (#2238)