Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Application: make app_entries private #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobby285271
Copy link

@bobby285271 bobby285271 commented Mar 19, 2022

Fixes compilation with latest valac (0.56), otherwise build fails with

../src/Application.vala:46.49-53.3: error: value is less accessible than constant `Tootle.Application.app_entries'
   46 |                 public const GLib.ActionEntry[] app_entries = {
      |                                                               ^
   47 |                         { "about", about_activated },
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   48 |                         { "compose", compose_activated },
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   49 |                         { "back", back_activated },
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   50 |                         { "refresh", refresh_activated },
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   51 |                         { "search", search_activated },
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   52 |                         { "switch-timeline", switch_timeline_activated, "i" }
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   53 |                 };
      |                 ~ 
Compilation failed: 1 error(s), 129 warning(s)
ninja: build stopped: subcommand failed.

(Note that we are also patching this app with #339 and #336, they are likely also needed to make this build with latest vala)

See also: elementary/mail#765

Fixes compilation with latest valac.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant